Conversation
ggml-ci
ggerganov
added
the
breaking change
ggerganov
commented
Dec 7, 2024
Comment on lines
-486
to
-491
| // Some idiosyncrasy in task processing logic makes several trailing calls | ||
| // with empty content, we ignore these at the calee site. | ||
| if (content.empty()) { | ||
| return std::vector<json>({json::object()}); | ||
| } | ||
|
|
ngxson
approved these changes
Dec 7, 2024
| add_executable(${TARGET} ${TARGET_SRCS}) | ||
| install(TARGETS ${TARGET} RUNTIME) | ||
|
|
||
| # clean up generated files in pre-build step |
Contributor
There was a problem hiding this comment.
just a note here, we should add a check in /scripts/xxd.cmake to see if the file need to be re-generated or not. I will do that in another PR.
Member
Author
There was a problem hiding this comment.
Ok. You mentioned that the /slots endpoint is also broken. I haven't looked at it yet. Maybe we can apply any additional fixes in this PR before merging? Feel free to push directly.
Contributor
There was a problem hiding this comment.
Yup I fixed it in 01da1ed
I also fix a problem with cpp wrapper llama_get_chat_template because it returns null terminator in the final json:
ggerganov
commented
Dec 7, 2024
Co-authored-by: Georgi Gerganov <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Dec 20, 2024
* server : various fixes ggml-ci * server : show curent seed in slot_params ggml-ci * fix /slots endpoint * Update examples/server/server.cpp Co-authored-by: Georgi Gerganov <[email protected]> * server : reflect endpoint response changes in the readme ggml-ci --------- Co-authored-by: Xuan Son Nguyen <[email protected]> Co-authored-by: Xuan Son Nguyen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
/slotsand/propsresponses have changed. See the updated READMEllama-serveron eachmaken_ctxfromslot_paramstoserver_slotserver_slot.to_json()