server : bugfix - stop server from sending empty json during oai chat completions#10694
Closed
m18coppola wants to merge 2 commits intoggml-org:masterfrom
Closed
server : bugfix - stop server from sending empty json during oai chat completions#10694m18coppola wants to merge 2 commits intoggml-org:masterfrom
m18coppola wants to merge 2 commits intoggml-org:masterfrom
Conversation
…_complete json object during oai chat streaming response
Member
|
It might be better to find what is the root cause for having this empty json object and prevent from being created in the first place. |
Member
|
I traced it and this empty object is created when an end-of-turn token is generated and the I think a better solution would be to send a valid object with empty content instead of skipping this message from the stream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #10643, the webui crashes when the model finished generating a response:

Upon investigation, I found that it was because an empty json object is sent from the server before the on_complete json is sent:
I made a change such that the server skips sending any empty json objects returned from the completion results stream.