Skip to content

fix(cogs): adjust cogs data based on retention #7855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
volokluev wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −2
Open

fix(cogs): adjust cogs data based on retention #7855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1d6170
adjust cogs data based on retention
volokluev Mar 31, 2026
8516206
comment
volokluev Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions rust_snuba/src/processors/eap_items.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,15 @@ fn process_eap_item(msg: KafkaPayload, config: &ProcessorConfig) -> anyhow::Resu
TraceItemType::Unspecified => "null",
}
.to_string();

// Depending on retention days, a trace item is more expensive.
// The default retention is 30 days, a 90day retention for an
// item would effectively mean that we are storing 3 times the payload size
let retention_days_multiplier = eap_item.retention_days / 30;
Copy link
Copy Markdown
Contributor

@onewland onewland Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is / with an int a quotient in rust?

if we ever had a 14d or 7d retention that would be a problem

let cogs_data = CogsData {
data: BTreeMap::from([(app_feature, payload.len() as u64)]),
data: BTreeMap::from([(
app_feature,
(retention_days_multiplier * payload.len()) as u64,
)]),
};

Ok(ProcessedItem {
Expand Down
Loading