fix(cogs): adjust cogs data based on retention#7855
Open
fix(cogs): adjust cogs data based on retention#7855
Conversation
xurui-c
approved these changes
Mar 31, 2026
Contributor
|
is consumer compute cost based off this number? because it shouldn't be affected |
onewland
reviewed
Mar 31, 2026
| // Depending on retention days, a trace item is more expensive. | ||
| // The default retention is 30 days, a 90day retention for an | ||
| // item would effectively mean that we are storing 3 times the payload size | ||
| let retention_days_multiplier = eap_item.retention_days / 30; |
Contributor
There was a problem hiding this comment.
is / with an int a quotient in rust?
if we ever had a 14d or 7d retention that would be a problem
Member
|
@onewland no, query usage ratio is applied to compute |
Contributor
I think we're talking about two different things. The consumers use compute (e.g. 32 or 64 pods or whatever) and ClickHouse uses compute to execute queries. For both, COGS should do some kind of division across item type. For the former, retention_days doesn't affect anything. For the latter, retention_days does probably matter (though it probably has less of an effect on compute than storage) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on retention days, a trace item is more expensive. The default retention is 30 days, a 90day retention for an item would mean that we are storing 3 times the payload size