Repository navigation
ref: Drop unused Cocoa scope serialization - #5754
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5754 +/- ##
==========================================
- Coverage 75.91% 75.82% -0.09%
==========================================
Files 519 519
Lines 19235 19235
Branches 3741 3741
==========================================
- Hits 14602 14585 -17
- Misses 3765 3781 +16
- Partials 868 869 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ric-oliv
reviewed
Oct 20, 2026
ric-oliv
left a comment
Member
There was a problem hiding this comment.
Hi @philprime, thanks for the PR!
It seems like SentryObjCScope is the only header that still exposes serialize, right? Instead of transforming and removing it, I left a suggestion to just remove the property as a whole.
Once v10 comes in, we can look at this again.
What do you think?
ric-oliv
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the unused Scope serialization binding through the binding patch generator. Runtime event serialization and scope-context enrichment already use Cocoa's internal APIs, so no runtime path changes.
Prepares for Cocoa's v10-only public serialization removal.
The Roslyn binding transformation was run locally and the resulting diff contains only the removed method. Full Sharpie regeneration and native builds were not run successfully because PowerShell and the pinned .NET workload are unavailable locally. CI will provide integration verification.
#skip-changelog