Skip to content

ref: Drop unused Cocoa scope serialization - #5754

Merged
ric-oliv merged 2 commits into
mainfrom
refactor/internal-cocoa-serialization
Oct 21, 2026
Merged

ric-oliv merged 2 commits into
mainfrom
refactor/internal-cocoa-serialization

Conversation

@philprime

Copy link
Copy Markdown
Member

Description

Remove the unused Scope serialization binding through the binding patch generator. Runtime event serialization and scope-context enrichment already use Cocoa's internal APIs, so no runtime path changes.

Prepares for Cocoa's v10-only public serialization removal.

The Roslyn binding transformation was run locally and the resulting diff contains only the removed method. Full Sharpie regeneration and native builds were not run successfully because PowerShell and the pinned .NET workload are unavailable locally. CI will provide integration verification.

#skip-changelog

@linear-code

linear-code Bot commented Oct 20, 2026

Copy link
Copy Markdown

COCOA-2091

@philprime philprime self-assigned this Oct 20, 2026
@philprime
philprime marked this pull request as ready for review October 20, 2026 13:58
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.82%. Comparing base (c9ad2be) to head (c7afe2a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5754      +/-   ##
==========================================
- Coverage   75.91%   75.82%   -0.09%     
==========================================
  Files         519      519              
  Lines       19235    19235              
  Branches     3741     3741              
==========================================
- Hits        14602    14585      -17     
- Misses       3765     3781      +16     
- Partials      868      869       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ric-oliv ric-oliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @philprime, thanks for the PR!

It seems like SentryObjCScope is the only header that still exposes serialize, right? Instead of transforming and removing it, I left a suggestion to just remove the property as a whole.

Once v10 comes in, we can look at this again.

What do you think?

Comment thread scripts/patch-cocoa-bindings.cs Resolved
@philprime
philprime requested a review from ric-oliv October 21, 2026 11:56
@ric-oliv
ric-oliv merged commit 92ec402 into main Oct 21, 2026
48 checks passed
@ric-oliv
ric-oliv deleted the refactor/internal-cocoa-serialization branch October 21, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants