Skip to content

Commit 92ec402

Browse files
philprimeric-oliv
andauthored
ref: Drop unused Cocoa scope serialization (#5754)
* ref: Drop unused Cocoa scope serialization --------- Co-authored-by: Ricardo Colombo Oliveira <github@ricoliv.com>
1 parent 876f7a6 commit 92ec402

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

‎scripts/patch-cocoa-bindings.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,9 @@
4444
.WithAttribute("*Sentry*", "Internal")
4545
// Remove INSCopying due to https://github.com/xamarin/xamarin-macios/issues/17130
4646
.RemoveBaseType("INSCopying")
47+
// Unused, and gated out of the public API for Cocoa v10 (getsentry/sentry-cocoa#9403).
48+
.RemoveProperty("SentryObjCScope", "Serialize")
4749
// Fix property-to-method conversions
48-
.PropertyToMethod("Sentry*", "Serialize")
4950
.PropertyToMethod("SentryObjCSpan", "ToTraceHeader")
5051
.PropertyToMethod("SentryObjCTraceContext", "ToBaggage")
5152
.PropertyToMethod("SentryObjCInternalScopeApi", "CreateScope")

‎src/Sentry.Bindings.Cocoa/ApiDefinition.cs‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1099,10 +1099,6 @@ interface SentryObjCScope
10991099
[NullAllowed, Export("span", ArgumentSemantic.Strong)]
11001100
SentryObjCSpan Span { get; set; }
11011101

1102-
// -(NSDictionary<NSString *,id> * _Nonnull)serialize;
1103-
[Export("serialize")]
1104-
NSDictionary<NSString, NSObject> Serialize();
1105-
11061102
// -(void)clear;
11071103
[Export("clear")]
11081104
void Clear();

0 commit comments

Comments
 (0)