ref(statsd): Migrate backend to metrics-exporter-dogstatsd#5675
Merged
ref(statsd): Migrate backend to metrics-exporter-dogstatsd#5675
Conversation
Dav1dde
force-pushed
the
dav1d/dogstatsd-metrics
branch
from
127376b to
0356496
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Dav1dde
force-pushed
the
dav1d/dogstatsd-metrics
branch
3 times, most recently
from
25dc97a to
5713e86
Compare
Dav1dde
force-pushed
the
dav1d/dogstatsd-metrics
branch
from
5713e86 to
1ad4af8
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
jjbayer
approved these changes
Mar 2, 2026
|
|
||
| let encoded_envelope = relay_statsd::metric!( | ||
| timer(RelayTimers::BufferEnvelopesSerialization, sample = 0.01), | ||
| timer(RelayTimers::BufferEnvelopesSerialization), |
Member
There was a problem hiding this comment.
Well have to verify that the buffer service load is still low.
CHANGELOG.md
Outdated
|
|
||
| **Breaking Changes**: | ||
|
|
||
| - Use a much more mature (dog)statsd backend, with proper support for unix sockets and reservoir sampling. |
Member
There was a problem hiding this comment.
Suggested change
| - Use a much more mature (dog)statsd backend, with proper support for unix sockets and reservoir sampling. | |
| - Use a more mature (dog)statsd backend, with proper support for unix sockets and reservoir sampling. |
Let's be nice to the old backend
Member
Author
There was a problem hiding this comment.
Fair, I was mostly referring to my botched version of the udp socket implementation, statsdproxy served us well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates away from
statsdproxytometrics-exporter-dogstatsdfrom themetricseco-system. This allows plugging into the much more powerful ecosystem ofmetrics. It also is a much more mature backend implementation.Notable changes:
While using the
metricseco-system, I kept our own facade alive, minimizing necessary changes on Relay. That said, it was still necessary to change some macro invocations (usually just small type changes).