Reverted deadlock fix (Affected other receivers)#104
Merged
oxtoacart merged 1 commit intogetlantern:masterfrom Nov 21, 2019
Merged
Reverted deadlock fix (Affected other receivers)#104oxtoacart merged 1 commit intogetlantern:masterfrom
oxtoacart merged 1 commit intogetlantern:masterfrom
Conversation
Contributor
|
Ha, sorry I didn't catch that in my review. I'm working on a solution now. |
ropog3ovomou
pushed a commit
to ropog3ovomou/systray
that referenced
this pull request
Jul 13, 2022
Reverted deadlock fix (Affected other receivers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR reverts a change made in PR #103 which originally addressed an issue in #101.
The previous PR ensured every
item.ClickedChhad at least one receiver assigned. This stopped the application from deadlocking when clicking menu items with no assigned Channel receivers.However, that change has adversely affected menu items with assigned channel receivers. They are currently not consistently being notified on item clicks. See https://stackoverflow.com/questions/15715605/multiple-goroutines-listening-on-one-channel.
Something more sophisticated would be required to handle item.ClickCh with no assigned receivers.
Apologies in advance for the previously introduced bug.