Fix Deadlock and item ordering in Windows#103
Merged
oxtoacart merged 2 commits intogetlantern:masterfrom Nov 20, 2019
Merged
Conversation
Contributor
|
LGTM, thanks @ldstein ! |
ropog3ovomou
pushed a commit
to ropog3ovomou/systray
that referenced
this pull request
Jul 13, 2022
Fix Deadlock and item ordering in Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR addresses two issues raised in #101:
Ensure all item.ClickCh channels have at least one receiver to avoid deadlocks.
nextActionId was incrementing too early, resulting in the second added item not being added to the actions map. Ie:
-- Item 0 is assigned to action 1
-- Item 1 is not added (because item 0 was assigned to action 1)