Skip to content

Fix pathPrefix #7182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KyleAMathews merged 2 commits into from
Aug 9, 2018
Merged

Fix pathPrefix #7182

KyleAMathews merged 2 commits into from
Aug 9, 2018

Conversation

@m-allanson
Copy link
Contributor

@m-allanson m-allanson commented Aug 9, 2018

Closes #7163

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 9, 2018

Deploy preview for using-postcss-sass failed.

Built with commit d09c0cc

https://app.netlify.com/sites/using-postcss-sass/deploys/5b6c398873f2cf194717b2d4

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 9, 2018

Deploy preview for using-drupal ready!

Built with commit d09c0cc

https://deploy-preview-7182--using-drupal.netlify.com

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 9, 2018

Deploy preview for using-postcss-sass failed.

Built with commit d1e0a91

https://app.netlify.com/sites/using-postcss-sass/deploys/5b6c39f7c9659205546ceee0

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 9, 2018

Deploy preview for gatsbygram ready!

Built with commit d09c0cc

https://deploy-preview-7182--gatsbygram.netlify.com

KyleAMathews
KyleAMathews approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@KyleAMathews KyleAMathews merged commit ce87aa4 into master Aug 9, 2018
@KyleAMathews KyleAMathews deleted the path-prefix branch August 9, 2018 13:03
@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 9, 2018

Deploy preview for using-remark failed.

Built with commit d1e0a91

https://app.netlify.com/sites/using-remark/deploys/5b6c39f7c9659205546ceeec

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 9, 2018

Deploy preview for using-drupal ready!

Built with commit d1e0a91

https://deploy-preview-7182--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 9, 2018

Deploy preview for gatsbygram ready!

Built with commit d1e0a91

https://deploy-preview-7182--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 9, 2018

Deploy preview for gatsbyjs failed.

Built with commit d1e0a91

https://app.netlify.com/sites/gatsbyjs/deploys/5b6c39f7c9659205546ceed8

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 9, 2018

Deploy preview for gatsbyjs failed.

Built with commit d09c0cc

https://app.netlify.com/sites/gatsbyjs/deploys/5b6c398773f2cf194717b2cc

m-allanson added a commit that referenced this pull request Aug 9, 2018
@m-allanson
Merge branch 'master' into graphql-codemod
d76f57c 
* master: (24 commits)
  chore(release): Publish
  Include pathPrefix in <Link /> (#7159)
  Add learnreact.design to sites.yml (#7185)
  Add DesignSystems.com & Devol’s Dance to Site Showcase (#7184)
  Fix pathPrefix (#7182)
  chore(release): Publish
  Fix simple-auth's build (#7175)
  chore(release): Publish
  Reduce the amount of pushes from the server during development (#7158)
  chore(release): Publish
  Don't set basepath w/ pathPrefix during builds (#7176)
  chore(release): Publish
  Fix hot reloading (#7178)
  chore(release): Publish
  improve modifyWebpackConfig error message (#7152)
  Add the email capture form on several more pages (#7084)
  Added Tech Confessions 🙏 (#7162)
  Add thibmaek.com to sites.yml (#7165)
  Update formatting and grammar (#7170)
  Delete Breaking Changes.md (#7179)
  ...
@KyleAMathews KyleAMathews mentioned this pull request Aug 10, 2018
Merged
porfirioribeiro pushed a commit to porfirioribeiro/gatsby that referenced this pull request Aug 22, 2018
@m-allanson @porfirioribeiro
Fix pathPrefix (gatsbyjs#7182)
615a4d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m-allanson @KyleAMathews @gatsbybot