Skip to content

Conversation

@KyleAMathews
Copy link
Contributor

We weren't wrapping the actual root component so it react-hot-loader
couldn't handle most (all?) code updates.

Fixes #6466

We weren't wrapping the actual root component so it react-hot-loader
couldn't handle most (all?) code updates.

Fixes #6466
@KyleAMathews
Copy link
Contributor Author

Deploy preview for using-postcss-sass failed.

Built with commit 3653614

https://app.netlify.com/sites/using-postcss-sass/deploys/5b6c0028dd28ef2669eee084

@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit 3653614

https://deploy-preview-7178--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit 3653614

https://deploy-preview-7178--gatsbygram.netlify.com

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌴

@KyleAMathews KyleAMathews merged commit a3eff30 into master Aug 9, 2018
@KyleAMathews KyleAMathews deleted the fix-hot branch August 9, 2018 10:01
m-allanson added a commit that referenced this pull request Aug 9, 2018
* master: (24 commits)
  chore(release): Publish
  Include pathPrefix in <Link /> (#7159)
  Add learnreact.design to sites.yml (#7185)
  Add DesignSystems.com & Devol’s Dance to Site Showcase (#7184)
  Fix pathPrefix (#7182)
  chore(release): Publish
  Fix simple-auth's build (#7175)
  chore(release): Publish
  Reduce the amount of pushes from the server during development (#7158)
  chore(release): Publish
  Don't set basepath w/ pathPrefix during builds (#7176)
  chore(release): Publish
  Fix hot reloading (#7178)
  chore(release): Publish
  improve modifyWebpackConfig error message (#7152)
  Add the email capture form on several more pages (#7084)
  Added Tech Confessions 🙏 (#7162)
  Add thibmaek.com to sites.yml (#7165)
  Update formatting and grammar (#7170)
  Delete Breaking Changes.md (#7179)
  ...
shobhitchittora pushed a commit to shobhitchittora/gatsby that referenced this pull request Aug 13, 2018
We weren't wrapping the actual root component so it react-hot-loader
couldn't handle most (all?) code updates.

Fixes gatsbyjs#6466
porfirioribeiro pushed a commit to porfirioribeiro/gatsby that referenced this pull request Aug 22, 2018
We weren't wrapping the actual root component so it react-hot-loader
couldn't handle most (all?) code updates.

Fixes gatsbyjs#6466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v2] hot reload not working for React components

4 participants