[pls review] Fix contentful image handling #4207
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,4 @@ | ||
| /__tests__ | ||
| /yarn.lock | ||
| /*.js | ||
| !index.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| module.exports.schemes = require(`./schemes.js`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| const { | ||
| GraphQLEnumType, | ||
| } = require(`graphql`) | ||
|
|
||
| const ImageFormatType = new GraphQLEnumType({ | ||
| name: `ContentfulImageFormat`, | ||
| values: { | ||
| NO_CHANGE: { value: `` }, | ||
| JPG: { value: `jpg` }, | ||
| PNG: { value: `png` }, | ||
| WEBP: { value: `webp` }, | ||
| }, | ||
| }) | ||
|
|
||
| const ImageResizingBehavior = new GraphQLEnumType({ | ||
| name: `ImageResizingBehavior`, | ||
| values: { | ||
| NO_CHANGE: { | ||
| value: ``, | ||
| }, | ||
| PAD: { | ||
| value: `pad`, | ||
| description: `Same as the default resizing, but adds padding so that the generated image has the specified dimensions.`, | ||
| }, | ||
|
|
||
| CROP: { | ||
| value: `crop`, | ||
| description: `Crop a part of the original image to match the specified size.`, | ||
| }, | ||
| FILL: { | ||
| value: `fill`, | ||
| description: `Crop the image to the specified dimensions, if the original image is smaller than these dimensions, then the image will be upscaled.`, | ||
| }, | ||
| THUMB: { | ||
| value: `thumb`, | ||
| description: `When used in association with the f parameter below, creates a thumbnail from the image based on a focus area.`, | ||
| }, | ||
| SCALE: { | ||
| value: `scale`, | ||
| description: `Scale the image regardless of the original aspect ratio.`, | ||
| }, | ||
| }, | ||
| }) | ||
|
|
||
| const ImageCropFocusType = new GraphQLEnumType({ | ||
| name: `ContentfulImageCropFocus`, | ||
| values: { | ||
| TOP: { value: `top` }, | ||
| TOP_LEFT: { value: `top_left` }, | ||
| TOP_RIGHT: { value: `top_right` }, | ||
| BOTTOM: { value: `bottom` }, | ||
| BOTTOM_RIGHT: { value: `bottom_left` }, | ||
| BOTTOM_LEFT: { value: `bottom_right` }, | ||
| RIGHT: { value: `right` }, | ||
| LEFT: { value: `left` }, | ||
| FACES: { value: `faces` }, | ||
| }, | ||
| }) | ||
|
|
||
| module.exports = { | ||
| ImageFormatType, | ||
| ImageResizingBehavior, | ||
| ImageCropFocusType, | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like something broke this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the outcome of the bugfix for this result
w=450&h=399b0c658cIt returned the original aspect ratio while the resulting one should be returned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh :-) cool!