[pls review] Fix contentful image handling #4207
Conversation
axe312ger
commented
Feb 23, 2018
axe312ger
commented
- Export the schemes for [Ready 4 Review] SQIP - Vectorized primitive image previews #4205
- Allow background image setting for proper output when cropping
- Return correct aspect ratio for responsive image nodes
|
Deploy preview for gatsbygram ready! Built with commit 03aa963 |
axe312ger
changed the title
|
@Khaledgarbaya maybe u can have a look :) |
| const resp = await resolveResponsiveSizes(image, { | ||
| maxWidth: 450, | ||
| maxHeight: 399, | ||
| maxHeight: 400, |
There was a problem hiding this comment.
Could you change this back to 399? It was set this way to test that rounding works I believe.
There was a problem hiding this comment.
Ohh, felt so weird to me to have such an non-practical height and a resulting aspect ratio of 1.1278195488721805
but yes, I can do that :)
| width: 450, | ||
| height: 399, | ||
| quality: 50, | ||
| background: `rgb:000000`, |
There was a problem hiding this comment.
The background is set when doing cropping operations where the source image does not completely cover the result.
axe312ger
force-pushed
the
fix/contentful-image-handling
branch
from
87a10d9 to
03aa963
Compare
|
@KyleAMathews this is ready for re-review :) |
| exports[`contentful extend node type resolveResponsiveSizes generates responsive sizes data for images using all options 1`] = ` | ||
| Object { | ||
| "aspectRatio": 0.75, | ||
| "aspectRatio": 1.1278195488721805, |
There was a problem hiding this comment.
Looks like something broke this?
There was a problem hiding this comment.
This is the outcome of the bugfix for this result w=450&h=399 b0c658c
It returned the original aspect ratio while the resulting one should be returned
|
Thanks! |
4 participants
