Skip to content

fix(gatsby-source-wordpress): fix preview issues #37492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2023
Merged

fix(gatsby-source-wordpress): fix preview issues #37492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac0e309
add fallback array to prevent errors when cachedNodeIds aren't passed
TylerBarnes Jan 17, 2023
541f833
if there's a token we're previewing - also await non node root fields…
TylerBarnes Jan 18, 2023
ce40f31
Merge branch 'master' into fix/wp-cached-node-ids-array
TylerBarnes Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions packages/gatsby-source-wordpress/src/steps/source-nodes/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,19 @@ import { sourcePreviews } from "~/steps/preview"
const sourceNodes: Step = async helpers => {
const { cache, webhookBody, refetchAll } = helpers

// fetch non-node root fields such as settings.
// For now, we're refetching them on every build
const nonNodeRootFieldsPromise = fetchAndCreateNonNodeRootFields()

// if this is a preview we want to process it and return early
if (webhookBody.preview) {
if (webhookBody.token && webhookBody.userDatabaseId) {
await sourcePreviews(helpers)

await nonNodeRootFieldsPromise
return
}
// if it's not a preview but we have a token
// we should source any pending previews then continue sourcing
else if (webhookBody.token && webhookBody.userDatabaseId) {
await sourcePreviews(helpers)
}

const now = Date.now()

// fetch non-node root fields such as settings.
// For now, we're refetching them on every build
const nonNodeRootFieldsPromise = fetchAndCreateNonNodeRootFields()

const lastCompletedSourceTime =
webhookBody.refreshing && webhookBody.since
? webhookBody.since
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby-source-wordpress/src/steps/source-nodes/update-nodes/wp-actions/update.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const fetchAndCreateSingleNode = async ({
singleName,
id,
actionType,
cachedNodeIds,
cachedNodeIds = [],
token = null,
isPreview = false,
isDraft = false,
Expand Down