fix(gatsby-source-wordpress): fix preview issues #37492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
added
topic: source-wordpress
DanielSLew
previously approved these changes
Jan 18, 2023
kathmbeck
previously approved these changes
Jan 18, 2023
TylerBarnes
dismissed stale reviews from kathmbeck and DanielSLew
via
541f833
TylerBarnes
changed the title
kathmbeck
approved these changes
Jan 18, 2023
tyhopp
pushed a commit
that referenced
this pull request
Jan 19, 2023
* add fallback array to prevent errors when cachedNodeIds aren't passed * if there's a token we're previewing - also await non node root fields for previews (cherry picked from commit 48d4069)
tyhopp
pushed a commit
that referenced
this pull request
Jan 19, 2023
* add fallback array to prevent errors when cachedNodeIds aren't passed * if there's a token we're previewing - also await non node root fields for previews (cherry picked from commit 48d4069)
tyhopp
pushed a commit
that referenced
this pull request
Jan 19, 2023
* add fallback array to prevent errors when cachedNodeIds aren't passed * if there's a token we're previewing - also await non node root fields for previews (cherry picked from commit 48d4069) Co-authored-by: Tyler Barnes <[email protected]>
Contributor
|
Backported to v5 in |
tyhopp
added a commit
that referenced
this pull request
Jan 19, 2023
* add fallback array to prevent errors when cachedNodeIds aren't passed * if there's a token we're previewing - also await non node root fields for previews (cherry picked from commit 48d4069) Co-authored-by: Tyler Barnes <[email protected]> Co-authored-by: Ty Hopp <[email protected]>
Contributor
|
Backported to v4 in |
Contributor
Author
|
Thanks @tyhopp ! |
This was referenced Apr 19, 2023
This was referenced Apr 19, 2023
This was referenced Apr 19, 2023
This was referenced Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #37478 I discovered there are some cases where not providing an empty array here as a default causes problems
I also realized the code checks for
webhookBody.previewwhich doesn't ever exist and as a result causes source-wordpress to re-source all data when restarting pods. So I simplified that check and fixed it