Skip to content

Do not parse numbers as dates in ambiguous cases #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Do not parse numbers as dates in ambiguous cases #3499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/gatsby/src/schema/__tests__/__snapshots__/infer-graphql-type-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ Object {
"date": "1984",
"title": "The world of slash and adventure",
},
"hair": 2,
"hair": 2048,
},
],
},
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby/src/schema/__tests__/infer-graphql-type-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ describe(`GraphQL type inferance`, () => {
id: `boo`,
name: `The Mad Wax`,
type: `Test`,
hair: 2,
hair: 2048,
date: `1984-10-12`,
anArray: [1, 2, 5, 4],
aNestedArray: [[1, 2, 3, 4]],
Expand Down
3 changes: 0 additions & 3 deletions packages/gatsby/src/schema/infer-graphql-type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,8 @@ export type ProcessedNodeType = {
}

const ISO_8601_FORMAT = [
`YYYY`,
`YYYY-MM`,
`YYYY-MM-DD`,
`YYYYMMDD`,
`YYYY-MM-DDTHHZ`,
`YYYY-MM-DDTHH:mmZ`,
`YYYY-MM-DDTHHmmZ`,
Expand All @@ -59,7 +57,6 @@ const ISO_8601_FORMAT = [
`YYYY-[W]WW-E`,
`YYYY[W]WWE`,
`YYYY-DDDD`,
`YYYYDDDD`,
]

function inferGraphQLType({
Expand Down