Do not parse numbers as dates in ambiguous cases #3499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number with four or eight digits was treated as a date if it matched one of the following date formats: YYYY, YYYYMMDD or YYYYMMDD
Collaborator
|
Deploy preview for gatsbygram ready! Built with commit 128f76b |
Contributor
|
Thanks for the PR! I think you're problem has already been solved though — checkout this PR #3461 Try upgrading to the latest Gatsby and tell us if there's any trouble still! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the
gatsby-transformer-jsonplugin to parse a raw JSON string into Javascript objects. Some of the values are numbers but some (not all) are coming through as strings after a GraphQL query.I believe this is due to them being treated as dates. In particular, a number with four or eight digits is treated as a date if it matched one of the following date formats: YYYY, YYYYMMDD or YYYYMMDD.
This PR removes these date formats from the matching criteria when inferring the GraphQL type. I think this is more in line with what a user would expect and still allows data which is more obviously a date to be parsed as expected.