Skip to content

Fix readline crash when using autocomplete with colored-completion-prefix turned on in Bash #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisJefferson wants to merge 1 commit into from
Closed

Fix readline crash when using autocomplete with colored-completion-prefix turned on in Bash #2986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/sysfiles.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2118,8 +2118,15 @@ int GAP_rl_func(int count, int key)
/* display matches */
if (!IS_LIST(data)) return 0;
dlen = LEN_LIST(data);
char **strs = (char**)malloc((dlen+1) * sizeof(char*));
// +2, so we have a null at the end, as this must be
// in 'argv' format
char **strs = (char**)calloc(dlen+2, sizeof(char*));
max = 0;
// TODO: Make this the current partially typed
// identifier which is, I think, the first argument to
// rl_display_match_list
char partial[] = {'\0'};
strs[0] = partial;
for (i=1; i <= dlen; i++) {
if (!IsStringConv(ELM_LIST(data, i))) {
free(strs);
Expand Down