Fix readline crash when using autocomplete with colored-completion-prefix turned on in Bash
#2986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Nov 9, 2018
This stops readline crashing if set colored-completion-prefix on is in ~/.inputrc. However, it doesn't make that option work, as (I believe) the first thing passed to rl_display_match_list should be the current partially written word
ChrisJefferson
force-pushed
the
readline-fix
branch
from
3c04f09 to
acd15cd
Compare
fingolfin
approved these changes
Nov 10, 2018
fingolfin
added
kind: bug: crash
Member
|
This code was originally written by @frankluebeck so perhaps he has further comments or insights? Otherwise, I'd just merge this next week. |
frankluebeck
added a commit
to frankluebeck/gap
that referenced
this pull request
Nov 11, 2018
This was reported including a first proposed fix by @ChrisJefferson ("Fix readline crash" gap-system#2986 in github.) With this patch the ~/.inputrc setting set colored-completion-prefix on should be supported correctly (by giving the word to be completed to readline's display function).
Member
|
See "Fl readline fix" (#2991) for a comment and an alternative pull request. |
Contributor
Author
|
closed because #2991 is better |
fingolfin
pushed a commit
that referenced
this pull request
Nov 13, 2018
This was reported including a first proposed fix by @ChrisJefferson ("Fix readline crash" #2986 in github.) With this patch the ~/.inputrc setting set colored-completion-prefix on should be supported correctly (by giving the word to be completed to readline's display function).
olexandr-konovalov
pushed a commit
that referenced
this pull request
Nov 24, 2018
This was reported including a first proposed fix by @ChrisJefferson ("Fix readline crash" #2986 in github.) With this patch the ~/.inputrc setting set colored-completion-prefix on should be supported correctly (by giving the word to be completed to readline's display function).
olexandr-konovalov
changed the title
colored-completion-prefix turned on in Bash
olexandr-konovalov
removed
the
release notes: to be added
fingolfin
added
the
kind: bug
ssiccha
pushed a commit
to ssiccha/gap
that referenced
this pull request
Mar 27, 2019
This was reported including a first proposed fix by @ChrisJefferson ("Fix readline crash" gap-system#2986 in github.) With this patch the ~/.inputrc setting set colored-completion-prefix on should be supported correctly (by giving the word to be completed to readline's display function).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops readline crashing if set colored-completion-prefix on
is in ~/.inputrc. However, it doesn't make that option work, as
(I believe) the first thing passed to rl_display_match_list should
be the current partially written word.
I am not going to further improve this PR, but I am happy or someone else to, or for it to be merged as is so at least we don't crash.