Print traceback when encountering errors #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssiccha
changed the title
Contributor
Author
|
This needs gap-system/gap#2551 to be merged. |
ssiccha
force-pushed
the
ss/use-gap-option-alwaystrace
branch
from
3d5366b to
21adbb7
Compare
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 61.24% 43.6% -17.65%
==========================================
Files 9 9
Lines 836 883 +47
==========================================
- Hits 512 385 -127
- Misses 324 498 +174
|
Contributor
Author
|
I've also added a little hack to let the JupyterKernel stay compatible with GAP 4.9.x versions. This is also relatively ugly, but otherwise JupyterKernel would become unusable until GAP 4.10 is released. |
markuspf
requested changes
Jul 10, 2018
Member
markuspf
left a comment
markuspf
left a comment
There was a problem hiding this comment.
Thanks, could you whitespace-cleanup JupyterError.gi?
ssiccha
force-pushed
the
ss/use-gap-option-alwaystrace
branch
from
21adbb7 to
b5f34ac
Compare
Contributor
Author
|
Done. Unless gap-system/gap#2551is merged into master the travis checks fail due to some "unbound global variable" syntax warning though. |
ssiccha
force-pushed
the
ss/use-gap-option-alwaystrace
branch
from
b5f34ac to
cfc21c5
Compare
Contributor
Author
|
I completely forgot about this pull request. Sorry! I just forgot to retrigger the tests once my patch was merged into the gap master branch... I removed the compatibility hack for 4.9 and made 4.10 a dependency in the PackageInfo.g file. |
Uses the new command line option --alwaystrace. This lets GAP also print tracebacks when the break loop is disabled by -T. This still overwrites the library functions Where, WHERE, and ErrorInner. This can be avoided once there is a central GAP error stream where these functions send their output, see gap-system/gap#1815. Since redirecting error messages was not available in 4.9 this also sets the required GAP version to >= 4.10. Fixes gap-packages#38.
ssiccha
force-pushed
the
ss/use-gap-option-alwaystrace
branch
from
cfc21c5 to
3c5bb76
Compare
ssiccha
changed the title
markuspf
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the new command line option --alwaystrace. This lets GAP
also print tracebacks when the break loop is disabled by -T.
This still overwrites the library functions Where, WHERE, and
ErrorInner. This can be avoided once there is a central GAP
error stream where these functions send their output, see
gap-system/gap#1815.
Fixes #38.