Use GAP library functions to handle errors (DONT MERGE) #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This needs gap-system/gap#2530 to be merged. |
ssiccha
force-pushed
the
ss/use-library-errors
branch
from
ebd0c6e to
3a1cd13
Compare
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 60.7% 64.29% +3.58%
==========================================
Files 9 8 -1
Lines 817 689 -128
==========================================
- Hits 496 443 -53
+ Misses 321 246 -75
|
ssiccha
force-pushed
the
ss/use-library-errors
branch
from
3a1cd13 to
1dfe63e
Compare
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
========================================
- Coverage 60.7% 50% -10.71%
========================================
Files 9 9
Lines 817 694 -123
========================================
- Hits 496 347 -149
- Misses 321 347 +26
|
Now that the GAP error functions can redirect their output to a chosen stream, the previously used hack is no longer needed. This commit provides a function JupyterOnBreak which prints a traceback and then skips the break loop by calling JUMP_TO_CATCH. When the jupyter kernel runs OnBreak is overwritten with JupyterOnBreak. To use this GAP is started without the -T option. Fixes gap-packages#38.
ssiccha
force-pushed
the
ss/use-library-errors
branch
from
1dfe63e to
36aeb0a
Compare
Contributor
Author
|
Now that the GAP error functions can redirect their output to a This commit provides a function JupyterOnBreak which prints a To use this GAP is started without the -T option. |
Contributor
Author
|
This needs gap-system/gap#2529 and gap-system/gap#2530 to be merged in order to work. |
ssiccha
changed the title
Contributor
Author
|
This is replaced by #70. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the GAP error functions can redirect their output to achosen stream, the previously used hack is no longer needed.
Also defines the variable IsRunningJupyterKernel when inside thekernel loop. This variable is used by the library to know when
to print the traceback although BreakOnError = false.
See new commit message below.
Fixes #38.