Skip to content

Conversation

@sanity
Copy link
Collaborator

@sanity sanity commented Sep 28, 2025

Removes the Pivotal Tracker sync workflow as it's no longer needed.

🤖 Generated with Claude Code

Removing Pivotal Tracker sync workflow as it's no longer needed.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@sanity sanity enabled auto-merge September 28, 2025 02:31
@claude
Copy link

claude bot commented Sep 28, 2025

PR Review: Remove pt_sync.yml workflow

Summary

This PR removes the Pivotal Tracker synchronization workflow. The change is straightforward and clean.

Code Quality ✅

  • Clean deletion of unused workflow file
  • No code smells or issues

Potential Issues ⚠️

  • Missing cleanup: The workflow references .github/scripts/pt_sync.py. If Pivotal Tracker is no longer being used, consider removing this script as well to avoid leaving dead code in the repository.
  • Secrets cleanup: The workflow uses PT_API_KEY and PT_PROJECT_ID secrets. Consider removing these from the repository settings if they're no longer needed.

Security Considerations ✅

  • Removing unused workflows reduces the attack surface
  • No security concerns with this deletion

Testing & Documentation 📝

  • No tests needed for workflow deletion
  • Consider updating any documentation that references Pivotal Tracker integration (if applicable)

Recommendation

LGTM with suggestions - The PR is good to merge. Consider the cleanup items mentioned above as follow-up tasks.


Reviewed by Claude Code

@sanity sanity added this pull request to the merge queue Sep 28, 2025
Merged via the queue into main with commit ee40348 Sep 28, 2025
8 checks passed
@sanity sanity deleted the remove-pt-sync branch September 28, 2025 02:51
claude bot pushed a commit that referenced this pull request Sep 28, 2025
- Remove pt_sync.yml workflow (removed in main via #1868)
- Update subscribe/tests.rs with latest test suite from main (498 lines)
- Preserve WebSocket SubscribeResponse fix for local contracts

Co-authored-by: Ian Clarke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants