-
Notifications
You must be signed in to change notification settings - Fork 0
Bump react and @types/react in /web-app #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Needs ReviewI recommend reviewing this upgrade before merging because this is a major version jump introducing significant breaking changes and a critical version mismatch. The codebase upgrades React from 18.3.1 to 19.2.0 but leaves react-dom at 18.3.1, creating an incompatible peer dependency that will cause runtime failures. Additionally, the package.json contains a resolution forcing @types/react back to 18.3.3, which conflicts with the upgrade to 19.2.0 and will cause TypeScript compilation errors. While the codebase already uses the modern createRoot API and avoids deprecated features like propTypes, defaultProps, and string refs, the version mismatches must be resolved and the 22 breaking changes must be validated against the 104 React components before deployment. What we checked
Dependency UsageReact is the foundational UI framework for this entire web application, with comprehensive usage across 104 component files spanning routing, authentication, state management, data visualization, file management, user administration, and bucket operations. The library enables all interactive user experiences through hooks like useState and useEffect for state and lifecycle management, functional components for UI composition, and SVG rendering for custom icons and visualizations. The TypeScript type definitions from @types/react provide compile-time type safety across the codebase while having no runtime impact, ensuring developer productivity and code quality without affecting the application bundle.
View 102 more usages
However, the import for "reac" seems to be incomplete, which might be a typo or a cut-off line.
To give a more precise description, I would need to see the complete component definition and implementation. The current snippet seems to be just importing dependencies and starting a type definition.
Other Usages (104)These usages were analyzed but no breaking changes were detected: react
ChangesReact has been upgraded with 22 breaking changes including mandatory Node.js 18+, removal of legacy APIs (propTypes, defaultProps, string refs, ReactDOM.render), and introduction of the new JSX transform requirement. The update adds 61 new features centered around Server Components, async Actions, form handling (useActionState, useFormStatus), document metadata support, and the new
View 280 more changes
References (7)[1]: CRITICAL: React upgraded to 19.2.0 but react-dom remains at 18.3.1 (line 19), creating an incompatible peer dependency that will cause runtime errors Line 16 in c61391c
[2]: CRITICAL: Resolution forces @types/react to 18.3.3, conflicting with the 19.2.0 upgrade on line 70 and causing TypeScript compilation failures Line 101 in c61391c
[3]: POSITIVE: Application already uses ReactDOM.createRoot (modern API), avoiding the breaking change that removed ReactDOM.render Line 24 in c61391c
[4]: POSITIVE: Code search found no usage of deprecated APIs (propTypes, defaultProps, contextTypes, string refs, createFactory) across all 104 React components [5]: Known ecosystem issue: Next.js projects fail to build with @types/react v19 due to type recognition problems, though this project uses react-scripts (source link) [6]: Official migration guide documents 22 breaking changes including Node.js 18+ requirement, removed APIs, and TypeScript namespace changes (source link) [7]: Widespread ERESOLVE conflicts reported with @testing-library/react and other ecosystem packages still requiring React 18 peer dependencies (source link) fossabot analyzed this PR using static analysis and dependency research. |
c61391c to
cb78e87
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together. Updates `react` from 18.3.1 to 19.2.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.0/packages/react) Updates `@types/react` from 18.3.23 to 19.2.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: react dependency-version: 19.2.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react" dependency-version: 19.2.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
cb78e87 to
3b74a79
Compare
Bumps react and @types/react. These dependencies needed to be updated together.
Updates
reactfrom 18.3.1 to 19.2.0Release notes
Sourced from react's releases.
... (truncated)
Changelog
Sourced from react's changelog.
... (truncated)
Commits
5667a41Bump next prerelease version numbers (#34639)8bb7241Bump useEffectEvent to Canary (#34610)e3c9656Ensure Performance Track are Clamped and Don't overlap (#34509)68f00c9Release Activity in Canary (#34374)0e10ee9[Reconciler] Set ProfileMode for Host Root Fiber by default in dev (#34432)3bf8ab4Add missing Activity export to development mode (#34439)1549bda[Flight] Only assign_storein dev mode when creating lazy types (#34354)bb6f0c8[Flight] Fix wrong missing key warning when static child is blocked (#34350)05addfcUpdate Flow to 0.266 (#34271)ec5dd0aUpdate Flow to 0.257 (#34253)Updates
@types/reactfrom 18.3.23 to 19.2.0Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)