Skip to content

Remove string refs (behind flag) #28322

Merged
acdlite merged 2 commits intofacebook:mainfrom
acdlite:remove-string-refs
Feb 27, 2024
Merged

Remove string refs (behind flag) #28322
acdlite merged 2 commits intofacebook:mainfrom
acdlite:remove-string-refs

Conversation

@acdlite
Copy link
Copy Markdown
Collaborator

@acdlite acdlite commented Feb 14, 2024

Depends on:


This removes string refs, which has been deprecated in Strict Mode for seven years.

I've left them behind a flag for Meta, but in open source this fully removes the feature.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 14, 2024
@react-sizebot
Copy link
Copy Markdown

react-sizebot commented Feb 14, 2024

Comparing: 3bcd2de...8bf8b67

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.89 kB 176.89 kB = 55.14 kB 55.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 179.20 kB 178.71 kB = 55.81 kB 55.66 kB
facebook-www/ReactDOM-prod.classic.js = 592.56 kB 592.56 kB = 104.73 kB 104.73 kB
facebook-www/ReactDOM-prod.modern.js = 576.34 kB 576.34 kB = 101.81 kB 101.81 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js = 43.72 kB 42.69 kB = 13.10 kB 12.84 kB
oss-experimental/react/cjs/react-jsx-runtime.development.js = 43.65 kB 42.62 kB = 13.08 kB 12.82 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.development.js = 42.42 kB 41.39 kB = 12.72 kB 12.48 kB
test_utils/ReactAllWarnings.js Deleted 66.36 kB 0.00 kB Deleted 16.25 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom.profiling.min.js = 188.67 kB 188.19 kB = 58.18 kB 58.03 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js = 187.93 kB 187.45 kB = 58.48 kB 58.34 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js = 185.25 kB 184.76 kB = 58.07 kB 57.93 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 179.20 kB 178.71 kB = 55.81 kB 55.66 kB
oss-experimental/react-dom/umd/react-dom.production.min.js = 178.91 kB 178.42 kB = 56.12 kB 55.98 kB
oss-experimental/react-dom/cjs/react-dom.profiling.js = 1,006.33 kB 1,003.57 kB = 223.96 kB 223.18 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js = 982.52 kB 979.76 kB = 220.93 kB 220.16 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 964.54 kB 961.78 kB = 216.43 kB 215.67 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,374.52 kB 1,369.98 kB = 303.79 kB 302.64 kB
oss-experimental/react-dom/umd/react-dom.development.js = 1,421.86 kB 1,417.15 kB = 302.54 kB 301.40 kB
oss-experimental/react-dom/cjs/react-dom.development.js = 1,356.66 kB 1,352.12 kB = 299.51 kB 298.38 kB
oss-experimental/react-art/umd/react-art.production.min.js = 139.40 kB 138.91 kB = 43.68 kB 43.53 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js = 745.26 kB 742.51 kB = 161.47 kB 160.70 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js = 126.71 kB 126.22 kB = 38.94 kB 38.84 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js = 704.06 kB 701.30 kB = 154.05 kB 153.30 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js = 117.66 kB 117.17 kB = 36.60 kB 36.44 kB
oss-experimental/react-art/cjs/react-art.production.js = 612.61 kB 609.85 kB = 137.19 kB 136.42 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 958.82 kB 954.28 kB = 205.74 kB 204.57 kB
oss-experimental/react-art/cjs/react-art.production.min.js = 102.20 kB 101.71 kB = 31.44 kB 31.29 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js = 866.07 kB 861.74 kB = 183.13 kB 182.00 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 827.13 kB 822.95 kB = 181.18 kB 180.05 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js = 617.21 kB 613.74 kB = 138.47 kB 137.43 kB
oss-experimental/react-art/umd/react-art.development.js = 974.68 kB 967.26 kB = 206.34 kB 204.16 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.production.js = 5.21 kB 5.17 kB = 2.25 kB 2.24 kB
oss-experimental/react/cjs/react-jsx-runtime.production.js = 5.14 kB 5.10 kB = 2.23 kB 2.22 kB
oss-experimental/react/cjs/react-jsx-runtime.profiling.js = 5.14 kB 5.10 kB = 2.23 kB 2.22 kB
oss-experimental/react-art/cjs/react-art.development.js = 857.55 kB 850.41 kB = 187.05 kB 184.90 kB
oss-experimental/react/umd/react.development.js = 124.85 kB 123.76 kB = 32.24 kB 31.99 kB
oss-experimental/react/cjs/react.development.js = 102.14 kB 101.08 kB = 27.61 kB 27.38 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js = 109.62 kB 108.40 kB = 34.02 kB 33.62 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js = 109.34 kB 108.11 kB = 33.65 kB 33.27 kB
oss-experimental/react/cjs/react.react-server.development.js = 83.33 kB 82.27 kB = 23.37 kB 23.12 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js = 43.72 kB 42.69 kB = 13.10 kB 12.84 kB
oss-experimental/react/cjs/react-jsx-runtime.development.js = 43.65 kB 42.62 kB = 13.08 kB 12.82 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.development.js = 42.42 kB 41.39 kB = 12.72 kB 12.48 kB
test_utils/ReactAllWarnings.js Deleted 66.36 kB 0.00 kB Deleted 16.25 kB 0.00 kB

Generated by 🚫 dangerJS against 8bf8b67

@acdlite acdlite force-pushed the remove-string-refs branch 4 times, most recently from 9a55f49 to edd9f4f Compare February 20, 2024 23:39
@acdlite acdlite marked this pull request as ready for review February 20, 2024 23:39
@acdlite acdlite requested a review from sebmarkbage February 20, 2024 23:39
This removes string refs, which has been deprecated in Strict Mode for
seven years.

I've left them behind a flag for Meta, but in open source this fully
removes the feature.
@acdlite acdlite merged commit c979895 into facebook:main Feb 27, 2024
github-actions Bot pushed a commit that referenced this pull request Feb 27, 2024
Depends on:

- #28398

---

This removes string refs, which has been deprecated in Strict Mode for
seven years.

I've left them behind a flag for Meta, but in open source this fully
removes the feature.

DiffTrain build for [c979895](c979895)
gnoff added a commit to gnoff/next.js that referenced this pull request Mar 25, 2024
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Depends on:

- facebook#28398

---

This removes string refs, which has been deprecated in Strict Mode for
seven years.

I've left them behind a flag for Meta, but in open source this fully
removes the feature.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Depends on:

- #28398

---

This removes string refs, which has been deprecated in Strict Mode for
seven years.

I've left them behind a flag for Meta, but in open source this fully
removes the feature.

DiffTrain build for commit c979895.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants