Merged
Conversation
achim-k
approved these changes
Jul 22, 2025
Collaborator
achim-k
left a comment
achim-k
left a comment
There was a problem hiding this comment.
Services unit tests now pass, which means all unit tests are now enabled and passing 🎉
🎉🎉
|
|
||
| if (j.find("request") != j.end() && j["request"].find("schema") != j["request"].end()) { | ||
| p.requestSchema = j["request"]["schema"].get<std::string>(); | ||
| } else if (j.find("requestSchema") != j.end()) { |
Collaborator
There was a problem hiding this comment.
I think we should no longer support the deprecated requestSchema and responseSchema fields
Contributor
Author
There was a problem hiding this comment.
Will update to throw an error
| } | ||
| for (auto serviceId : servicesToRemove) { | ||
| _advertisedServices.erase(serviceId); | ||
| for (auto serviceName : servicesToRemove) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| for (auto serviceName : servicesToRemove) { | |
| for (const auto& serviceName : servicesToRemove) { |
otherwise you are making a copy of every string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
None
Docs
None
Description
Migrate service functionality to use the Foxglove SDK.
GenericClient code was updated to use
foxglove::Responderdirectly instead of storingstd::functioninstances for callbacks, as move-onlyResponderobjects now handle responding to the client, and lambdas that capture them are not convertible tostd::function. This also obviated the need to handle futures/promises in the GenericClient, and now-dead future code was removed.Services unit tests now pass, which means all unit tests are now enabled and passing 🎉
Fixes: FG-12234