Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Apr 3, 2025

This PR depends on fox-it/dissect.fve#6

@JSCU-CNI JSCU-CNI changed the title Add unlock_with_raw_key to BitlockerVolumeSystem Add unlock_with_fvek to BitlockerVolumeSystem Apr 7, 2025
@JSCU-CNI JSCU-CNI requested a review from Schamper April 7, 2025 08:50
@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.33%. Comparing base (5aa44b6) to head (02fff05).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/volumes/bde.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
- Coverage   79.36%   79.33%   -0.03%     
==========================================
  Files         347      347              
  Lines       31004    31012       +8     
==========================================
- Hits        24606    24604       -2     
- Misses       6398     6408      +10     
Flag Coverage Δ
unittests 79.33% <62.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JSCU-CNI
Copy link
Contributor Author

JSCU-CNI commented Apr 7, 2025

Seems like the dependency resolving for the regular install vs dev extra is not working.

@Schamper
Copy link
Member

Schamper commented Apr 7, 2025

Let's take the same approach as taken in #1064

@Schamper Schamper merged commit fe3ca7d into fox-it:main Apr 7, 2025
18 of 23 checks passed
@JSCU-CNI JSCU-CNI deleted the feature/bde-raw-key-unlock branch April 7, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants