Skip to content

Conversation

@twiggler
Copy link
Contributor

@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.11%. Comparing base (12306a3) to head (abe2e7a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   79.11%   79.11%           
=======================================
  Files         341      341           
  Lines       30155    30155           
=======================================
  Hits        23856    23856           
  Misses       6299     6299           
Flag Coverage Δ
unittests 79.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper
Copy link
Member

Good to go as soon as the other one is approved and merged.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the minor version should be bumped in pyproject.toml.

"dissect.ffs>=3,<4",
"dissect.fve>=4,<5; platform_system != 'Windows' or platform_python_implementation != 'PyPy'",
"dissect.jffs>=1,<2",
"dissect.jffs>=1.5.dev,<2", # TODO: update on release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you've created a ticket for this (internally) or do you wish to wait for a release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can wait for the next release

@twiggler twiggler merged commit 5b223d8 into main Apr 1, 2025
20 of 22 checks passed
@twiggler twiggler deleted the nlink-ffs branch April 1, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants