-
Notifications
You must be signed in to change notification settings - Fork 71
feature: add nlink support for jffs stat #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
=======================================
Coverage 79.11% 79.11%
=======================================
Files 341 341
Lines 30155 30155
=======================================
Hits 23856 23856
Misses 6299 6299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Good to go as soon as the other one is approved and merged. |
Schamper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the minor version should be bumped in pyproject.toml.
| "dissect.ffs>=3,<4", | ||
| "dissect.fve>=4,<5; platform_system != 'Windows' or platform_python_implementation != 'PyPy'", | ||
| "dissect.jffs>=1,<2", | ||
| "dissect.jffs>=1.5.dev,<2", # TODO: update on release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you've created a ticket for this (internally) or do you wish to wait for a release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can wait for the next release
Companion to https://github.com/fox-it/dissect.jffs/pull/13/files