Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Apr 1, 2025

This PR adds support for Cellebrite's UFDX and UFD full filesystem (FFS) exports. This has only been tested on Digital Corpora's iOS 17 image. This PR loosely relates to #1085 as the image OS is recognized correctly with that branch.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 1, 2025 14:06
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some small things. I like the small custom filesystem subclass, usually I would've just inlined that logic in the map method itself, but this has its benefits.

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 91.73554% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.15%. Comparing base (adda634) to head (22fb9fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/loaders/cellebrite.py 89.79% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
+ Coverage   79.10%   79.15%   +0.04%     
==========================================
  Files         341      342       +1     
  Lines       30181    30281     +100     
==========================================
+ Hits        23875    23968      +93     
- Misses       6306     6313       +7     
Flag Coverage Δ
unittests 79.15% <91.73%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 1, 2025 16:18
@JSCU-CNI JSCU-CNI requested a review from Schamper April 1, 2025 16:46
@Schamper Schamper merged commit e65a678 into fox-it:main Apr 1, 2025
19 of 22 checks passed
@JSCU-CNI JSCU-CNI deleted the feature/add-ufdx-loader branch April 2, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants