Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Apr 1, 2025

This PR improves the detection for iOS targets in dissect. The following OS functions should now work on iOS:

  1. users
  2. architecture
  3. hostname
  4. version
  5. activity
  6. install_date
  7. timezone
  8. language

We have also added an applications plugin.

@JSCU-CNI
Copy link
Contributor Author

JSCU-CNI commented Apr 2, 2025

Added tests for iOS in 8402ec9.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 2, 2025 10:51
@JSCU-CNI JSCU-CNI force-pushed the improvement/ios-detection branch from dc4a8f2 to dca5cd9 Compare April 2, 2025 13:03
@JSCU-CNI JSCU-CNI requested a review from Schamper April 2, 2025 13:03
@JSCU-CNI JSCU-CNI force-pushed the improvement/ios-detection branch from 171b4cd to 8631f02 Compare April 7, 2025 10:48
@JSCU-CNI JSCU-CNI requested a review from Schamper April 7, 2025 12:00
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the tests? Looks like a missing from __future__ import annotations somewhere.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 7, 2025 12:18
@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 92.89100% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.35%. Comparing base (2ffb153) to head (4bafc51).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t/target/plugins/os/unix/bsd/darwin/ios/generic.py 68.75% 5 Missing ⚠️
dissect/target/plugins/os/unix/bsd/darwin/_os.py 89.28% 3 Missing ⚠️
...ssect/target/plugins/os/unix/bsd/darwin/ios/_os.py 95.23% 3 Missing ⚠️
...ect/target/plugins/os/unix/bsd/darwin/macos/_os.py 88.23% 2 Missing ⚠️
dissect/target/loaders/local.py 0.00% 1 Missing ⚠️
...get/plugins/os/unix/bsd/darwin/ios/applications.py 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   79.26%   79.35%   +0.08%     
==========================================
  Files         348      352       +4     
  Lines       31133    31263     +130     
==========================================
+ Hits        24679    24808     +129     
- Misses       6454     6455       +1     
Flag Coverage Δ
unittests 79.35% <92.89%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JSCU-CNI
Copy link
Contributor Author

JSCU-CNI commented Apr 9, 2025

Seems like the tests are fixed. Is this PR good to go?

@Schamper Schamper merged commit dc3bb86 into fox-it:main Apr 10, 2025
19 of 23 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/ios-detection branch April 10, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants