-
Notifications
You must be signed in to change notification settings - Fork 71
Improve detection for iOS targets #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Added tests for iOS in 8402ec9. |
dc4a8f2 to
dca5cd9
Compare
Co-authored-by: Erik Schamper <[email protected]>
Co-authored-by: Erik Schamper <[email protected]>
171b4cd to
8631f02
Compare
Schamper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the tests? Looks like a missing from __future__ import annotations somewhere.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
+ Coverage 79.26% 79.35% +0.08%
==========================================
Files 348 352 +4
Lines 31133 31263 +130
==========================================
+ Hits 24679 24808 +129
- Misses 6454 6455 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Seems like the tests are fixed. Is this PR good to go? |
This PR improves the detection for iOS targets in dissect. The following OS functions should now work on iOS:
usersarchitecturehostnameversionactivityinstall_datetimezonelanguageWe have also added an
applicationsplugin.