Skip to content

Use RangeStream when writing a block to ASDF #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Use RangeStream when writing a block to ASDF #28

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c422fc8
Add RangeStream to _write_block for ASDF
sud0woodo Apr 9, 2024
05fa1cf
Fix linting
sud0woodo Apr 9, 2024
be15db2
Fix argument for shutil.copyobj
sud0woodo Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dissect/evidence/asdf/asdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

from dissect import cstruct
from dissect.util import ts
from dissect.util.stream import AlignedStream
from dissect.util.stream import AlignedStream, RangeStream

from dissect.evidence.asdf.streams import CompressedStream, Crc32Stream, HashedStream
from dissect.evidence.exceptions import (
Expand Down Expand Up @@ -311,8 +311,8 @@ def _write_block(self, source: BinaryIO, offset: int, size: int, idx: int = 0, b
block.write(self.fh)
data_offset = self.fh.tell() # Block data location

source.seek(offset)
shutil.copyfileobj(source, outfh, size)
source_stream = RangeStream(source, offset, size)
shutil.copyfileobj(source_stream, outfh)
# This writes any remaining data or footer for each block writer
outfh.finalize()

Expand Down