Use RangeStream when writing a block to ASDF #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the use of a RangeStream for the _write_block function in the AsdfWriter. This allows to write ASDF files given a list of blocks. For some reason it would not update the offset and keep seeking to the same offset within the given range, using the RangeStream as a source for shutil.copyfileobj fixes this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
=======================================
Coverage 64.03% 64.03%
=======================================
Files 11 11
Lines 1012 1012
=======================================
Hits 648 648
Misses 364 364
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
After digging into it somewhat deeper it turns out that the way we use `shutil.copyobj` was wrong and the `size` argument was interpreted differently. Using the `RangeStream` still fixes the issue that we only read a specified length of bytes, whilst before the `size` argument was interpreted as the size that the buffer should have after reading whilst this is actually the block size for reading the bytes. Removed the `size` as an argument to `shutil.copyobj`, using `RangeStream` to make sure we read the specified amount of bytes in `size`.
Schamper
changed the title
Schamper
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a misinterpretation of the
lengthargument ofshutil.copyfileobj, it was being wrongly used. UsingRangeStreamhere will give the correct behaviour.