fix(fmt): filter libs when recursing #12119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrusowsky
requested review from
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
grandizzy
reviewed
Oct 16, 2025
Collaborator
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
makes sense, left a comment re test
grandizzy
pushed a commit
to grandizzy/foundry
that referenced
this pull request
Oct 16, 2025
* fix(fmt): account for ternary operators when estimating size * fix(fmt): filter libs when recursing * style: clippy * test: wipe contracts before formatting * test: explicitly test ignore
3 tasks
grandizzy
added a commit
that referenced
this pull request
Oct 18, 2025
* fix(anvil): eth_getAccountInfo check if predates fork inclusive (#12101) * fix(doc): follow tab width fmt config (#12103) * fix(fmt): account for ternary operators when estimating size (#12104) * fix(fmt): account for ternary operators when estimating size (#12112) * fix(fmt): properly handle multiline_func_header = "all" + bump alloy (#12110) * fix: don't normalize single-line non-doc block cmnts * fix: preserve consecutive whitespaces * fix: use byte length instead of char count * fix(fmt): properly handle multiline_func_header = "all" * fix: bump alloy * fix: bump alloy * chore: bump version to 1.4.2 (#12113) * fix(fmt): handle trailing coments between base contracts (#12127) * fix(fmt): account for ternary operators when estimating size * fix(fmt): handle comments between inherited base contracts * test: layout + base inheritance * fix(fmt): filter libs when recursing (#12119) * fix(fmt): account for ternary operators when estimating size * fix(fmt): filter libs when recursing * style: clippy * test: wipe contracts before formatting * test: explicitly test ignore * fix(fmt): break try stmts in a fn header-like fashion (#12131) * fix(fmt): use nbsp if LHS-most element fits (#12135) * fix(fmt): use nbsp if LHS-most element fits * fix(fmt): use nbsp if LHS-most element fits * reset cache inside helper * fix(fmt): prioritize parenthesis breaks in emit and revert stmts (#12147) * fix(fmt): prioritize parenthesis breaks in emit and revert stmts * fix(fmt): respect bracket spacing when printing commasetp without delimiters --------- Co-authored-by: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #12118
Solution
when the input path requires discovery (i.e.
., orlib/.) check if it is a lib path. If it is not, ignore libs.PR Checklist