Skip to content

Conversation

@0xrusowsky
Copy link
Contributor

Motivation

closes #12109

Solution

handle missing style variant

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@0xrusowsky 0xrusowsky marked this pull request as ready for review October 15, 2025 15:04
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@zerosnacks zerosnacks changed the title fix(fmt): properly handle multiline_func_header = "all" fix(fmt): properly handle multiline_func_header = "all" + bump alloy Oct 15, 2025
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@grandizzy grandizzy merged commit 5a6e167 into master Oct 15, 2025
16 checks passed
@grandizzy grandizzy deleted the rusowsky/12109 branch October 15, 2025 15:39
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 15, 2025
@grandizzy grandizzy mentioned this pull request Oct 15, 2025
3 tasks
grandizzy pushed a commit to grandizzy/foundry that referenced this pull request Oct 15, 2025
…oundry-rs#12110)

* fix: don't normalize single-line non-doc block cmnts

* fix: preserve consecutive whitespaces

* fix: use byte length instead of char count

* fix(fmt): properly handle multiline_func_header = "all"

* fix: bump alloy

* fix: bump alloy
grandizzy added a commit that referenced this pull request Oct 18, 2025
* fix(anvil): eth_getAccountInfo check if predates fork inclusive (#12101)

* fix(doc): follow tab width fmt config (#12103)

* fix(fmt): account for ternary operators when estimating size (#12104)

* fix(fmt): account for ternary operators when estimating size (#12112)

* fix(fmt): properly handle multiline_func_header = "all" + bump alloy (#12110)

* fix: don't normalize single-line non-doc block cmnts

* fix: preserve consecutive whitespaces

* fix: use byte length instead of char count

* fix(fmt): properly handle multiline_func_header = "all"

* fix: bump alloy

* fix: bump alloy

* chore: bump version to 1.4.2 (#12113)

* fix(fmt): handle trailing coments between base contracts (#12127)

* fix(fmt): account for ternary operators when estimating size

* fix(fmt): handle comments between inherited base contracts

* test: layout + base inheritance

* fix(fmt): filter libs when recursing (#12119)

* fix(fmt): account for ternary operators when estimating size

* fix(fmt): filter libs when recursing

* style: clippy

* test: wipe contracts before formatting

* test: explicitly test ignore

* fix(fmt): break try stmts in a fn header-like fashion (#12131)

* fix(fmt): use nbsp if LHS-most element fits (#12135)

* fix(fmt): use nbsp if LHS-most element fits

* fix(fmt): use nbsp if LHS-most element fits

* reset cache inside helper

* fix(fmt): prioritize parenthesis breaks in emit and revert stmts (#12147)

* fix(fmt): prioritize parenthesis breaks in emit and revert stmts

* fix(fmt): respect bracket spacing when printing commasetp without
delimiters

---------

Co-authored-by: 0xrusowsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Forge formatter is not respecting multiline_func_header value

4 participants