Skip to content

fix Tax information pop up in Wizard step 1 showing up towards bottom of screen #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sachinchauhan2889 wants to merge 1 commit into from
Closed

fix Tax information pop up in Wizard step 1 showing up towards bottom of screen #5368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions app/components/modals/modal-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,18 @@ import { isTesting } from 'open-event-frontend/utils/testing';

export default UiModal.extend({
tagName : 'div',
classNameBindings : ['isFullScreen:fullscreen', 'isSmall:small', 'isLarge:large'],
classNameBindings : ['isFullScreen:fullscreen', 'isSmall:small', 'isLarge:large', 'noCropper'],

openObserver: observer('isOpen', function() {
openObserver: observer('isOpen', 'noCroppper', function() {
const $element = $(this.element);
if (this.isOpen) {
$element.modal('show');
if (this.noCropper) {
$element.modal({
centered: false
}).modal('show');
} else {
$element.modal('show');
}
Copy link
Member

@niranjan94 niranjan94 Oct 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Trailing spaces not allowed.

} else {
$element.modal('hide');
}
Expand Down
4 changes: 1 addition & 3 deletions app/components/modals/tax-info-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ import { orderBy } from 'lodash-es';

export default ModalBase.extend(FormMixin, {
isSmall : false,
options : {
closable: false
},
noCropper : true,

autoScrollToErrors : true,
isTaxIncludedInPrice : 'include',
Expand Down
5 changes: 5 additions & 0 deletions app/styles/partials/overrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,8 @@ body.dimmable.undetached.dimmed {
}
}
}

.no-cropper {
margin-left: auto !important;
margin-top: 50px !important;
}
1 change: 1 addition & 0 deletions app/templates/components/modals/tax-info-modal.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<i class="red close icon"></i>
<div class="header">
{{t 'Add tax information'}}
</div>
Expand Down