fix Tax information pop up in Wizard step 1 showing up towards bottom of screen

[sachinchauhan2889]

Fixes #4505

Short description of what this resolves:

The issue with pop up tax information box is resolved. Now the pop up tax information modal is positioned well. The pop up is fully visible(not hidden by any other area). The session notify modal is placed at suitable placed. I have checked this modal from every scroll position and found result upto mark. Now position of session notify modal is perfect.
Along with this, this PR also add "close" x icon on its top right of modal.

Changes proposed in this pull request:

• The issue with position of tax information modal is resolved.
• Add "close" x icon on its top right of modal.

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

screenshots

before

after

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9lfehvvq5
✅ Preview: https://open-event-frontend-git-align-tax-information-modal-4505.eventyay.now.sh

[codecov]

Codecov Report

Merging #5368 into development will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development    #5368      +/-   ##
===============================================
- Coverage        22.78%   22.77%   -0.01%     
===============================================
  Files              491      491              
  Lines             5245     5247       +2     
  Branches            37       37              
===============================================
  Hits              1195     1195              
- Misses            4045     4047       +2     
  Partials             5        5              

Impacted Files	Coverage Δ
app/components/modals/modal-base.js	23.52% <0.00%> (-1.48%)	⬇️
app/components/modals/tax-info-modal.js	22.22% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbdbe76...3169a3d. Read the comment docs.

[iamareebjamal]

Why creating 2-3 PRs with same changes? Wait for a PR to be merged or solve all of these issues in the same PR

[niranjan94]

Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

See the complete overview on Codacy

[niranjan94]

Codacy found an issue: Trailing spaces not allowed.

[sachinchauhan2889]

Why creating 2-3 PRs with same changes? Wait for a PR to be merged or solve all of these issues in the same PR

@iamareebjamal sorry, i am new to open source still understanding open source. i will take care of this.

[mariobehling]

Thank you!

• Could you keep the overlay background semitransparent white, please for consistency?
• Please make the X button black (on white background).
• When a user closes the pop up using the X button and then clicks add tax information again nothing happens. Expected: It should open the pop up again.

[iamareebjamal]

All 3 PR touch same file and make same changes and have same issues. To keep the conversation in one place where I have suggested changes, I am closing the other 2 PRs. Please make the changes in a single PR

[iamareebjamal]

See #5367