Skip to content
This repository was archived by the owner on Apr 30, 2018. It is now read-only.

fix(FormlyFormController): Fix validateOnModelChange not firing with promise change #523 #728

Merged
merged 1 commit into from
Jan 20, 2017
Merged

fix(FormlyFormController): Fix validateOnModelChange not firing with promise change #523 #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/directives/formly-form.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export default function FormlyFormController(
function validateFormControl(formControl, promise) {
const validate = formControl.$validate
if (promise) {
promise.then(validate)
promise.then(() => validate.apply(formControl))
} else {
validate()
Copy link
Contributor

@BarryThePenguin BarryThePenguin Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about this line?

Copy link
Member

@kentcdodds kentcdodds Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that the problem is that the validate function isn't being called with the right this context. Honestly, I'd prefer the use of bind personally, but I don't care either way.

Copy link
Contributor

@BarryThePenguin BarryThePenguin Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. LGTM

}
Expand Down