This repository was archived by the owner on Apr 30, 2018. It is now read-only.
fix(FormlyFormController): Fix validateOnModelChange not firing with promise change #523 #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…promise change Fixes validate being called with undefined this variable scope. Closes formly-js#523
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/formly-js/angular-formly/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
Current coverage is 95.93% (diff: 100%)@@ master #728 diff @@
==========================================
Files 17 17
Lines 1181 1181
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1133 1133
Misses 48 48
Partials 0 0
|
Member
|
Could someone from @angular-formly-collaborators review and merge this? |
Member
|
Sorry, bad @ mention. Someone from @formly-js/angular-formly-collaborators please review and merge this. Thanks. |
| promise.then(validate) | ||
| promise.then(() => validate.apply(formControl)) | ||
| } else { | ||
| validate() |
Contributor
There was a problem hiding this comment.
what about this line?
Member
There was a problem hiding this comment.
I was thinking that the problem is that the validate function isn't being called with the right this context. Honestly, I'd prefer the use of bind personally, but I don't care either way.
Merged
3 tasks
aluanhaddad
added a commit
to aluanhaddad/angular-formly
that referenced
this pull request
Jul 23, 2017
…ange (formly-js#728) (#1) Fixes validate being called with undefined this variable scope. Closes formly-js#523
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In FormlyFormController in function validateFormControl variable validate was invoked with "undefined" this if the function was called with a promise.
Why
It's a bug.
How
Used a closure and apply() to ensure validate() will be called with formController as this.
For issue #523
Checklist:
Fixes validate being called with undefined this variable scope.
Closes #523