Fix for the http client proxy overriding the default client#943
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Jun 24, 2021
Merged
Conversation
bug introduced by fluxcd#872 Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com>
Member
|
@L3o-pold can you please confirm that this change fixes the metrics client when a proxy is set for an alert? |
stefanprodan
changed the title
Contributor
Author
|
@stefanprodan works great now. Alerting works with the proxy and metrics without as expected. |
stefanprodan
approved these changes
Jun 24, 2021
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @L3o-pold for the fix 🏅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug introduced by #872
Signed-off-by: Léopold Jacquot leopold.jacquot@infomaniak.com