Add alerting http proxy option#872
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Apr 28, 2021
Merged
Conversation
c2c6407 to
acd0006
Compare
Codecov Report
@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 56.68% 56.58% -0.11%
==========================================
Files 67 67
Lines 5439 5463 +24
==========================================
+ Hits 3083 3091 +8
- Misses 1896 1910 +14
- Partials 460 462 +2
Continue to review full report at Codecov.
|
Member
|
@L3o-pold thank you for this! Can you confirm that this works with and without the proxy setting? Have you tested it with Slack or MS Teams? |
acd0006 to
f639ff9
Compare
Signed-off-by: Léopold Jacquot <[email protected]>
f639ff9 to
b82fd5e
Compare
Contributor
Author
|
@stefanprodan I tested with and without proxy setting with Slack provider. |
L3o-pold
added a commit
to L3o-pold/flagger
that referenced
this pull request
Jun 24, 2021
bug introduced by fluxcd#872 Signed-off-by: Léopold Jacquot <[email protected]>
L3o-pold
added a commit
to L3o-pold/flagger
that referenced
this pull request
Jun 24, 2021
bug introduced by fluxcd#872 Signed-off-by: Léopold Jacquot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #871