Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@sir-boformer
Copy link
Contributor

Fixes flutter/flutter#20481

There can only be one declaration for each FileProvider subclass. That means to declare multiple file providers without collisions, one must create a (empty) subclass of android.support.v4.content.FileProvider and use that as the provider name in the manifest.

In my opinion, android.support.v4.content.FileProvider should be reserved for the app itself so that developers can easily add a file provider to their app, without subclassing FileProvider. It's also used in the Android documentation and in StackOverflow answers.

image_picker and other plugins should subclass FileProvider to prevent collisions (also collisions between plugins).

This issue describes a similar problem in an Android library.

@sir-boformer sir-boformer changed the title Use FileProvider subclass to avoid collisions image_picker: Use FileProvider subclass to avoid collisions Aug 11, 2018
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants