-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Improve image_picker android dependencies #715
Conversation
|
See also this PR #712 which I'm waiting for it to be merged |
goderbauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you please bump the version number in the pubspec.yaml and update the Changelog so we can merge & publish this change? Thanks!
|
@goderbauer Done. While we are at it, can you take a look at #716? |
goderbauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge after I have resolved the analyzer issue.
|
I think the analyzer issues are now resolved? I bumped the version number again because 0.4.7 was already taken |
|
Can you also update the version in the pubspec.yaml? |
|
done |
|
This is live on pub now. |
|
@goderbauer we started getting issues with this today. Although this might seem a small change but its not a revision change. Because of the dependency change it should at least be a minor version change. I believe that's in the semver recommendations. Either way, it breaks a lot of builds that use Currently any 3rd party library, firebase/google or other that depend on play-services currently will break. All of the play service libraries depend on So for the moment we're building against https://mvnrepository.com/artifact/com.google.android.gms/play-services-basement/15.0.1 |
|
@slightfoot To fix this, add this to your build.gradle: dependencies {
...
implementation 'com.android.support:support-v4:27.1.1'
}@goderbauer The dependency change introduced by this PR caused issues for quite a few people (at least 2 reports today. I also experienced issues when I added Firebase to my app a few days ago, because Firebase ships with an old version of the support library. To fix this, one must explicitly add the full support library as a dependency. Maybe it would be better to add the full support library dependency again? It is technically not required for image_picker (and increases the APK size by 1MB), but makes it easier to use for people who use Firebase or other outdated libraries. |
|
@sir-boformer For now we should probably change the dependency back. Do you want to send a PR? |
|
I'm having this issue trying to using the current package of image_picker |
This reverts commit 4bfc421.
Fixes flutter/flutter#20482
I'm not sure why the old build gradle used
apiinstead ofimplementationfor the dependency.apiis not required, so I fixed that as well.