Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@mklim
Copy link
Contributor

@mklim mklim commented Jul 22, 2019

Description

This pacakge should be removed entirely soon, so remove it from CI so we
don't spend further time on analyzer failures.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this requires bumping the minimal Flutter version required to the first release where the template parameter was added.

This pacakge should be removed entirely soon, so remove it from CI so we
don't spend further time on analyzer failures.
@mklim mklim changed the title [location_background] Fix new analyzer errors [location_background] Ignore for CI Jul 22, 2019
@mklim
Copy link
Contributor Author

mklim commented Jul 22, 2019

I think this requires bumping the minimal Flutter version required to the first release where the template parameter was added.

Blacklisted it from our CI checks instead like we discussed offline.

@collinjackson collinjackson self-requested a review July 22, 2019 23:09
@mklim mklim merged commit f8ebf95 into flutter:master Jul 23, 2019
@mklim mklim deleted the fix_ci branch July 23, 2019 00:12
@amirh
Copy link
Contributor

amirh commented Jul 24, 2019

CI seems to still be failing, e.g: https://cirrus-ci.com/task/5899696759898112

@collinjackson
Copy link
Contributor

I'll fix the location_background issue in #1884 but this is still worth investigating

@mklim
Copy link
Contributor Author

mklim commented Jul 24, 2019

@amirh @collinjackson figured out the underlying issue. I missed a branch in incremental_build.sh where it decides to analyze every single package if it's running on master, and not just the $CHANGED_PACKAGES like it does on PRs. So this PR doesn't do anything to prevent the analyze checks when CI is running on master commits itself. Will fix in a follow up.

mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
This pacakge should be removed entirely soon, so remove it from CI so we
don't spend further time on analyzer failures.
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
This pacakge should be removed entirely soon, so remove it from CI so we
don't spend further time on analyzer failures.
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* Initial release of cloud_functions_web
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants