Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Jul 20, 2019

as surfaced in https://cirrus-ci.com/task/6499769273286656

package_info issue was referenced in discussion flutter/flutter#11154 (comment)

@collinjackson collinjackson requested a review from cyanglaz as a code owner July 20, 2019 15:55
@collinjackson collinjackson requested a review from kroikie July 20, 2019 16:35
@collinjackson collinjackson changed the title [package_info] Fix Android compiler warnings [package_info] Fix remaining Android compiler warnings Jul 20, 2019
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@collinjackson
Copy link
Contributor Author

I added testing to prevent future build warnings from creeping in: https://github.com/flutter/plugin_tools/pull/47

@collinjackson collinjackson changed the title [package_info] Fix remaining Android compiler warnings [package_info] [location_background] Fix remaining Android compiler warnings Jul 24, 2019
@collinjackson
Copy link
Contributor Author

Landing on red to fix tests

@collinjackson collinjackson merged commit af86b9d into flutter:master Jul 24, 2019
@collinjackson collinjackson deleted the package_info_deprecation_warning branch July 24, 2019 21:28
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
…arnings (flutter#1884)

* Fix Android compiler warnings

* Fix deprecation warnings for location plugin

* Specify min Flutter SDK
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants