-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Recommend 4.3.0 version of google-services in READMEs/examples #1885
Recommend 4.3.0 version of google-services in READMEs/examples #1885
Conversation
kroikie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Landing this on red because the analyzer failures are a known issue (see #1882) and iOS build timeouts cannot be caused by Android-only changes. |
|
Thanks for this @collinjackson! Is this type of thing something that Coming up to speed with Flutter feels like I spend the same amount of effort hunting down Magic Boilerplate issues as I do figuring out what's wrong with my own code. |
| description: Demonstrates how to use the firebase_messaging plugin. | ||
|
|
||
| dependencies: | ||
| firebase_analytics: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@collinjackson Why was this added? Is it recommended to also depend on firebase_analytics when you use firebase_messaging?
Per discussion flutter/flutter#28770 (comment)
We can prevent these deprecation warnings by updating to a newer version of google-services gradle plugin.
This change will cause warnings to be emitted to the console the first time building after upgrading an app's google-services.
Subsequent builds will not have the error.
Fixes fluttere/flutter#28982