Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@tvolkert
Copy link
Contributor

No description provided.

@amirh
Copy link
Contributor

amirh commented Jul 19, 2019

It seems like the breaking change is potentially forcing packages to decide whether they want to support Flutter master or stable? left a comment on flutter/flutter#34626 (comment)

@collinjackson
Copy link
Contributor

Once https://github.com/flutter/flutter/pull/36577/files is landed I think this PR can be closed without merging

@tvolkert
Copy link
Contributor Author

Note the discussion in flutter/flutter#34545 (comment) and below. tldr: I still might not land flutter/flutter#36577. If it doesn't land, the way callers can be safe on both master and stable at the same time would be to explicitly pass initialData: null to the default StreamBuilder constructor.

@collinjackson
Copy link
Contributor

collinjackson commented Jul 21, 2019

Marking this PR as WIP since the new StreamBuilder API is still under discussion on flutter/flutter#34545, feel free to close or leave it open and ping us when it's ready for review.

@collinjackson
Copy link
Contributor

We're closing this PR as part of the migration to a new repository but feel free to re-open it there once the new StreamBuilder API is finalized.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants