This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_messaging] add integration tests #1816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
changed the title
collinjackson
changed the title
cyanglaz
approved these changes
Jul 8, 2019
| @@ -1,3 +1,7 @@ | |||
| ## 4.0.0+4 | |||
Contributor
There was a problem hiding this comment.
Probably should be 4.0.1 since post 1.0.0.
Suggested change
| ## 4.0.0+4 | |
| ## 4.0.1 |
| author: Flutter Team <[email protected]> | ||
| homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_messaging | ||
| version: 4.0.0+3 | ||
| version: 4.0.0+4 |
Contributor
There was a problem hiding this comment.
nits:
Suggested change
| version: 4.0.0+4 | |
| version: 4.0.1 |
| }); | ||
|
|
||
| test('subscribeToTopic', () async { | ||
| firebaseMessaging.subscribeToTopic('foo'); |
Contributor
There was a problem hiding this comment.
Some idea, doesn't need to be in this PR. Maybe we can make subscribeToTopic and unsubscribeFromTopic to return a Future to indicate the invocation to the platform is happened correctly. That'd make the integration test easier.
Contributor
Author
There was a problem hiding this comment.
I agree, and will update in a subsequent PR
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
* Initial firebase_messaging integration tests
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Initial firebase_messaging integration tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a test for #1756 (crash on Android calling deleteInstanceId)