Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@wildtigon
Copy link
Contributor

@wildtigon wildtigon commented Jun 18, 2019

Description

Make result of deleteInstanceID function return in correct UI Thread

Related Issues

flutter/flutter#33265

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@wildtigon
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@kroikie kroikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wildtigon thanks for the PR, would you mind using the same approach we have in the cloud_firestore plugin for this?

Also bumping the Version and CHANGELOG would help.

Dat Nguyen added 2 commits June 25, 2019 16:57
)

* Rebase onto master
* Switch from Looper to runOnUIThread
* Dumping version and change log
@wildtigon wildtigon requested a review from collinjackson as a code owner June 25, 2019 10:05
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@wildtigon
Copy link
Contributor Author

@kroikie: Sorry for late reply, I've changed it to runOnUiThread way. Since deleteInstanceID function in Firebase core doesn't give us callback method. I just want to make small change.

Another question. I've used another PC with broken email information to commit. I can't access this to this to verify alternate email address. Could you help me how can I re-sign CLA in this PR again ?

Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I added integration tests in #1816.

CLA looks fine.

@collinjackson collinjackson merged commit c34a7be into flutter:master Jul 8, 2019
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
…lt in incorrect thread (flutter#1756)

* [firebase_messaging] fix crash when calling func deleteInstanceID (flutter#1756)
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
…lt in incorrect thread (flutter#1756)

* [firebase_messaging] fix crash when calling func deleteInstanceID (flutter#1756)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants