-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[firebase_messaging] fix crash when func deleteInstanceID return result in incorrect thread #1756
[firebase_messaging] fix crash when func deleteInstanceID return result in incorrect thread #1756
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wildtigon thanks for the PR, would you mind using the same approach we have in the cloud_firestore plugin for this?
Also bumping the Version and CHANGELOG would help.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@kroikie: Sorry for late reply, I've changed it to runOnUiThread way. Since deleteInstanceID function in Firebase core doesn't give us callback method. I just want to make small change. Another question. I've used another PC with broken email information to commit. I can't access this to this to verify alternate email address. Could you help me how can I re-sign CLA in this PR again ? |
collinjackson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…lt in incorrect thread (flutter#1756) * [firebase_messaging] fix crash when calling func deleteInstanceID (flutter#1756)
…lt in incorrect thread (flutter#1756) * [firebase_messaging] fix crash when calling func deleteInstanceID (flutter#1756)
Description
Make result of deleteInstanceID function return in correct UI Thread
Related Issues
flutter/flutter#33265
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change