Skip to content

[go_router] Fix missing build parameter in type-safe routes topic documentation #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Oct 12, 2023
Merged

[go_router] Fix missing build parameter in type-safe routes topic documentation #5040

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d64d8e
[go_router] Fix missing build parameter in type-safe routes topic
yamhoresh Sep 30, 2023
afd567c
[go_router] Update changelog for documentation fix
yamhoresh Sep 30, 2023
d42e39d
Merge branch 'main' into patch-1
yamhoresh Oct 12, 2023
4fe75fe
[go_router] fix: resolve CHANGELOG merge conflict
yamhoresh Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/go_router/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 11.1.3

* Fixes missing parameters in the type-safe routes topic documentation.

## 11.1.2

- Fixes a bug where the known routes and initial route were logged even when `debugLogDiagnostics` was set to `false`.
Expand Down
4 changes: 2 additions & 2 deletions packages/go_router/doc/type-safe-routes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ part 'go_router_builder.g.dart';
@immutable
class HomeScreenRoute extends GoRouteData {
@override
Widget build(BuildContext context) {
Widget build(BuildContext context, GoRouterState state) {
return const HomeScreen();
}
}
Expand All @@ -44,7 +44,7 @@ class SongRoute extends GoRouteData {
});

@override
Widget build(BuildContext context) {
Widget build(BuildContext context, GoRouterState state) {
return SongScreen(songId: id.toString());
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/go_router/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: go_router
description: A declarative router for Flutter based on Navigation 2 supporting
deep linking, data-driven routes and more
version: 11.1.2
version: 11.1.3
repository: https://github.com/flutter/packages/tree/main/packages/go_router
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22

Expand Down