[go_router] Fix missing build parameter in type-safe routes topic documentation#5040
Merged
Conversation
Added the missing GoRouterState state parameter to the build methods.
Member
|
@yamhoresh can you fix the merge conflict? |
Contributor
Author
|
@Hangyujin Sure thing, I'm on it. |
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2023
…opic documentation (flutter/packages#5040)
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 13, 2023
flutter/packages@93c3f69...fd84e65 2023-10-12 48316647+yamhoresh@users.noreply.github.com [go_router] Fix missing build parameter in type-safe routes topic documentation (flutter/packages#5040) 2023-10-12 engine-flutter-autoroll@skia.org Roll Flutter (stable) from ead4559 to 2f708eb (1 revision) (flutter/packages#5134) 2023-10-12 goderbauer@google.com [web_benchmarks] Bump process version constraints (flutter/packages#5122) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…umentation (flutter#5040) Added the missing GoRouterState state parameter to the build methods of `HomeScreenRoute` and `SongRoute`, to the type-safe routes [topic](https://github.com/flutter/packages/blob/main/packages/go_router/doc/type-safe-routes.md). Using the current documentation (without the fix), raises the error: ``` dart 'HomeScreenRoute.build' ('Widget Function(BuildContext)') isn't a valid override of 'GoRouteData.build' ('Widget Function(BuildContext, GoRouterState)') ``` I didn't find any issue for this, but if you'd want I could simply open one myself and link it to this pull request.
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…umentation (flutter#5040) Added the missing GoRouterState state parameter to the build methods of `HomeScreenRoute` and `SongRoute`, to the type-safe routes [topic](https://github.com/flutter/packages/blob/main/packages/go_router/doc/type-safe-routes.md). Using the current documentation (without the fix), raises the error: ``` dart 'HomeScreenRoute.build' ('Widget Function(BuildContext)') isn't a valid override of 'GoRouteData.build' ('Widget Function(BuildContext, GoRouterState)') ``` I didn't find any issue for this, but if you'd want I could simply open one myself and link it to this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the missing GoRouterState state parameter to the build methods of
HomeScreenRouteandSongRoute, to the type-safe routes topic.Using the current documentation (without the fix), raises the error:
I didn't find any issue for this, but if you'd want I could simply open one myself and link it to this pull request.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.