Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Cherrypick disable hardware buffer platform views for 3.16 #46952

Closed
johnmccutchan wants to merge 233 commits into from
Closed

Cherrypick disable hardware buffer platform views for 3.16 #46952

johnmccutchan wants to merge 233 commits into from

Conversation

@johnmccutchan
Copy link
Contributor

@johnmccutchan johnmccutchan commented Oct 16, 2023

No description provided.

skia-flutter-autoroll and others added 30 commits September 28, 2023 22:18
@skia-flutter-autoroll
Roll Skia from 33502f9b0c7d to 08485e753e3a (1 revision) (#46384)
7a4277a 
https://skia.googlesource.com/skia.git/+log/33502f9b0c7d..08485e753e3a

2023-09-28 [email protected] Add emitTextureSamplersForFPs method to ProgramBuilder.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bdero
Bump impeller-cmake to head (#46385)
5a0747e 
Weekly bump
[Impeller] revert stencil config changes. (#46386)
3b07a6c 
This was an experiment that didn't really pan out. Revert the changes to simplify rendering logic.
@skia-flutter-autoroll
Roll Fuchsia Mac SDK from 4WW3KRrAbuY7VeGT0... to Ta8wiQnzbBc7fAGeR... (
2052515 
#46387)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll
Roll Skia from 08485e753e3a to 75033613a49f (2 revisions) (#46396)
ccb3058 
https://skia.googlesource.com/skia.git/+log/08485e753e3a..75033613a49f

2023-09-29 [email protected] Roll Skia Infra from d0c5366041fc to c8eb90e92f62 (2 revisions)
2023-09-29 [email protected] Roll Dawn from 1b2986736fd2 to a42cebae4e42 (19 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll
Roll Skia from 75033613a49f to a80c164ffb8a (3 revisions) (#46399)
09130bf 
https://skia.googlesource.com/skia.git/+log/75033613a49f..a80c164ffb8a

2023-09-29 [email protected] Roll ANGLE from 929ace8da386 to 1cab871c2207 (8 revisions)
2023-09-29 [email protected] Roll SK Tool from c8eb90e92f62 to a17b968c91ef
2023-09-29 [email protected] Roll vulkan-deps from 34349287c876 to 4d31920a095a (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@knopp
[macOS] Ensure first responder is consistent during and after text in…
8b4e633 
…put (#46032)

Fixes flutter/flutter#134906
Fixes flutter/flutter#133832

This ensures that there are only two first responder widgets -
`FlutterView` when text input is not active and `TextInputPlugin` when
text input is active. The PR also prevents `FlutterView` stealing first
responder status on mouse click events during text input.

Previously when `TextInputClient` resigned it made `nextResponder` the
first responder, but that was incorrect - `nextResponder` being the
superview (`FlutterViewWrapper`).

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
@dependabot
Bump webdriver from 3.0.2 to 3.0.3 in /lib/web_ui (#46400)
0d6ce53 
Bumps [webdriver](https://github.com/google/webdriver.dart) from 3.0.2 to 3.0.3.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/google/webdriver.dart/blob/master/CHANGELOG.md">webdriver's changelog</a>.</em></p>
<blockquote>
<h2>3.0.3</h2>
<ul>
<li>Include a content-type header when sending requests from <code>async_html.dart</code>.
The content-type is necessary for compatibility with GeckoDriver 0.27.0 and
newer versions.  The content-type header was already being sent in IO clients
for a long time, so only the HTML client had to be updated.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/google/webdriver.dart/commits">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=webdriver&package-manager=pub&previous-version=3.0.2&new-version=3.0.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
@skia-flutter-autoroll
Roll Fuchsia Linux SDK from l2RxJKPfYn7QzGOoL... to vbw3Gwj-6eN7rSqb4…
db4d3b5 
…... (#46401)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll
Roll Fuchsia Mac SDK from Ta8wiQnzbBc7fAGeR... to mR_mhiacGiD-ObsoG... (
c52251a 
#46403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@gaaclarke
[Impeller] Implements canvas recorder with trace serializer (#46376)
150d1b6 
This implements a portion of impeller canvas recorder that just prints
log statements to understand what is getting rendered in impeller when
executing code from the framework. Eventually this should get moved to
the displaylist layer when we have golden and interactive tests at that
layer.

This was useful for me to debug a fidelity issue, the hope is that
others will find it useful and can expand it as necessary. Eventually
the recordings can be used to generate tests.

design doc:
[go/impeller-canvas-recorder](http://goto.google.com/impeller-canvas-recorder)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
@skia-flutter-autoroll
Roll Skia from a80c164ffb8a to 9f8242377455 (1 revision) (#46406)
d5fcd78 
https://skia.googlesource.com/skia.git/+log/a80c164ffb8a..9f8242377455

2023-09-29 [email protected] Fix latent bug in fragmentProcessorHasCoordsParam.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll
Roll Skia from 9f8242377455 to 2d4045f55fd5 (3 revisions) (#46408)
bb1dbed 
https://skia.googlesource.com/skia.git/+log/9f8242377455..2d4045f55fd5

2023-09-29 [email protected] Add support for null child FPs to SkMesh.
2023-09-29 [email protected] Pass mesh children into MeshOp and Mesh geometry processor.
2023-09-29 [email protected] Add fontations gm to Bazel build of viewer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll
Manual roll Dart SDK from 077d768accfa to e042e83c85a5 (3 revisions) (#…
516d08b 
…46409)

Manual roll requested by [email protected]

https://dart.googlesource.com/sdk.git/+log/077d768accfa..e042e83c85a5

2023-09-29 [email protected] Version 3.2.0-213.0.dev
2023-09-29 [email protected] Version 3.2.0-212.0.dev
2023-09-28 [email protected] Version 3.2.0-211.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
[Impeller] simplify invert colors flag by supporting composed color f…
7326ccb 
…ilters. (#46391)

Fixes flutter/flutter#135699

To avoid the ugly complicated code for conditionally applying both colorfilters, make the dl dispatcher handle merging these filters together in a defined order. The original bug is caused by not checking for invert colors in a CPU fast path.
@auto-submit
Reverts "[Impeller] simplify invert colors flag by supporting compose…
cbb6039 
…d color filters." (#46414)

Reverts #46391
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
Fixes flutter/flutter#135699

To avoid the ugly complicated code for conditionally applying both colorfilters, make the dl dispatcher handle merging these filters together in a defined order. The original bug is caused by not checking for invert colors in a CPU fast path.
@skia-flutter-autoroll
Manual roll Dart SDK from e042e83c85a5 to 955a3a964621 (2 revisions) (#…
48973d7 
…46412)

Manual roll requested by [email protected]

https://dart.googlesource.com/sdk.git/+log/e042e83c85a5..955a3a964621

2023-09-29 [email protected] Version 3.2.0-215.0.dev
2023-09-29 [email protected] Version 3.2.0-214.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll
Roll Skia from 2d4045f55fd5 to a063eaeaf1e0 (6 revisions) (#46420)
845dd9d 
https://skia.googlesource.com/skia.git/+log/2d4045f55fd5..a063eaeaf1e0

2023-09-29 [email protected] Revert "Reland "[skif] Draw FilterResults directly for layer restoration""
2023-09-29 [email protected] Add CI jobs to test external_client build of "buffet" options
2023-09-29 [email protected] Revert "Add fontations gm to Bazel build of viewer"
2023-09-29 [email protected] Add fast-reject when SkStream implements getLength() but not getPosition()
2023-09-29 [email protected] Roll vulkan-deps from 4d31920a095a to 8ac5d8e1a9fe (3 revisions)
2023-09-29 [email protected] Reland "[skif] Draw FilterResults directly for layer restoration"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@eyebrowsoffire
Use dart:_wasm constructs to avoid dependence on `WebAssembly.Funct…
58fd524 
…ion` (#46388)

Use the newly exposed functionality in `dart:_wasm` to fix up two different hacks we have:
1) When creating an image from an image source, use `wasm:import` instead of `@Native` and pass the image source directly as an externref. (Direct wasm binding instead of a JS interop shim, yay).
2) When binding the surface callback, previously we were wrapping the callback in a JS function, and then using `WebAssembly.Function` to create a wasm function wrapper around that. Now, we can create a `WasmFuncRef` that is a direct reference to a dart function and pass that over. Now there are no intermediary JavaScript layers when skwasm calls back to us, and we no longer are dependent on the type reflection flag in Chrome.

This fixes flutter/flutter#134556
[Impeller] Redo simplify invert colors. (#46416)
f7f4b51 
Now with fewer state bugs.

Fixes flutter/flutter#135699
@skia-flutter-autoroll
Roll Dart SDK from 955a3a964621 to 0931bb8a43c8 (1 revision) (#46423)
c92565a 
https://dart.googlesource.com/sdk.git/+log/955a3a964621..0931bb8a43c8

2023-09-29 [email protected] Version 3.2.0-216.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@dkwingsmt
Multi-view Rasterizer (#45512)
d203e34 
This PR refactors `Rasterizer` so that it's more suitable for multi-view.

Design doc: [flutter.dev/go/multi-view-pipeline-and-rasterizer](http://flutter.dev/go/multi-view-pipeline-and-rasterizer)

With this change, `Rasterizer::DrawToSurfaces` has a structure that can handle drawing to multiple views, although the lack of some functionality still blocks it, mostly related to `ExternalViewEmbedder` and `RasterCache`. 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@skia-flutter-autoroll
Roll Fuchsia Linux SDK from vbw3Gwj-6eN7rSqb4... to U0lgvzao-MdzfEvoT…
779ce34 
…... (#46424)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Disable enableHardwareBufferRenderingTarget (#46425)
6a13607 
* Causing flickering in web views
* Follow up of cl/569435819 for Google to unblock the rolls
@skia-flutter-autoroll
Roll Fuchsia Mac SDK from mR_mhiacGiD-ObsoG... to vSGsxh_81aaf5CdfW... (
8939f9c 
#46427)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@johnmccutchan
Add an AndroidManifest.xml flag to disable ImageReader backed Platfor…
87c3bf1 
…m Views (#46430)

An internal customer is seeing flickering on some high FPS phones.

While we try and reproduce / gain more knowledge of this problem this PR adds a AndroidManifest.xml flag to disable their usage.

The boolean flag is:
```
"io.flutter.embedding.android.DisableImageReaderPlatformViews"
```

Adding the following to your manifest will disable their usage:

```
<meta-data
  android:name="io.flutter.embedding.android.DisableImageReaderPlatformViews"
  android:value="true" />
```
@gaaclarke
[Impeller] fixed subpass filter coverage with image filters (#46431)
e719b79 
fixes: flutter/flutter#135777
fixes: flutter/flutter#135766
fixes: flutter/flutter#135212

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
@skia-flutter-autoroll
Roll Dart SDK from 0931bb8a43c8 to 9aca08d40398 (1 revision) (#46432)
f505e50 
https://dart.googlesource.com/sdk.git/+log/0931bb8a43c8..9aca08d40398

2023-09-30 [email protected] Version 3.2.0-217.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jason-simmons
[Impeller] Apply the transform to PointFieldGeometry coverage (#46428)
f3a4cab 
Fixes flutter/flutter#134068
@skia-flutter-autoroll
Roll Dart SDK from 9aca08d40398 to 4574906880c1 (1 revision) (#46435)
0b96a82 
https://dart.googlesource.com/sdk.git/+log/9aca08d40398..4574906880c1

2023-09-30 [email protected] Version 3.2.0-218.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll and others added 23 commits October 11, 2023 09:50
@skia-flutter-autoroll
Roll Skia from 11e41e0e2f9f to e00577618d81 (1 revision) (#46763)
bddb34b 
https://skia.googlesource.com/skia.git/+log/11e41e0e2f9f..e00577618d81

2023-10-11 [email protected] Roll ANGLE from 0afc3ec95439 to ea332c715575 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll
Roll Skia from e00577618d81 to c05effecb081 (1 revision) (#46770)
ec1d0d6 
https://skia.googlesource.com/skia.git/+log/e00577618d81..c05effecb081

2023-10-11 [email protected] [webgpu-headers] Removes macros for "count" fields.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll
Roll Skia from c05effecb081 to 60d51fd2c6bd (3 revisions) (#46772)
c96ac16 
https://skia.googlesource.com/skia.git/+log/c05effecb081..60d51fd2c6bd

2023-10-11 [email protected] [graphite] Fix bugs in RasterPathAtlas caching.
2023-10-11 [email protected] Annotate third_party imports
2023-10-11 [email protected] [tint][gn] Disable GLSL validation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll
Roll Skia from 60d51fd2c6bd to bfd9af01b785 (2 revisions) (#46774)
68a8ff7 
https://skia.googlesource.com/skia.git/+log/60d51fd2c6bd..bfd9af01b785

2023-10-11 [email protected] Revert "[bazel] Move test runners under //tools/testrunners."
2023-10-11 [email protected] [graphite] Move RasterPathAtlas into AtlasProvider.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@zanderso
Roll goldctl forward (#46771)
65226ab 
For flutter/flutter#135620
@skia-flutter-autoroll
Roll Fuchsia Mac SDK from mLc-VlVTg-p18HjiP... to Qjz4zE4Oe0AO_7T3f... (
ed67e8a 
#46778)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bdero
[Impeller] Avoid invalid GL depth calls on macOS desktop. (#46758)
4b02631 
The macOS desktop driver doesn't support ES profiles, and
`glClearDepthf` + `glDepthRangef` are throwing `GL_INVALID_OPERATION`
and doing nothing. Noticed this while updating impeller-cmake past
@matanlurey's recent changes to make `GL_INVALID_OPERATION` fatal.
Impeller-cmake-example uses a depth buffer, whereas Impeller's 2D
renderer currently does not.

Added a follow-up bug to make these calls work on macOS desktop:
flutter/flutter#136322.
Both Impeller Scene and the impeller-cmake-example currently just rely
on the default state for clearing depth.
@skia-flutter-autoroll
Roll Skia from bfd9af01b785 to 6cc9f73ea54e (1 revision) (#46784)
85e1dd9 
https://skia.googlesource.com/skia.git/+log/bfd9af01b785..6cc9f73ea54e

2023-10-11 [email protected] Avoid symbol-shadowing when inlining functions.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@johnmccutchan
Fix 303652511 and add a regression test (#46743)
5fcc167 
Fixes internal bug b/303652511 and includes a regression test.

The TL;DR of the bug is that when re-launching a singleton-cached-engine
Flutter activity using FLAG_ACTIVITY_CLEAR_TASK, the teardown of the
previous Flutter activity interleaves with the creation of the new
Flutter activity, resulting in the Flutter engine ending up incorrectly
in the AppLifecycleState.detached state. This then results in the app
being completely unresponsive because Flutter doesn't draw frames in
this state. I don't know if the issue is reproducible in production
under normal user operation, but I'm concerned it very easily could be.
There's also nothing stopping other apps or Android system code from
launching an app using this flag.
@skia-flutter-autoroll
Roll Skia from 6cc9f73ea54e to 2459d71707e0 (1 revision) (#46787)
2b1b4b9 
https://skia.googlesource.com/skia.git/+log/6cc9f73ea54e..2459d71707e0

2023-10-11 [email protected] Roll vulkan-deps from bd2d26113aa7 to baab66a8258b (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@johnmccutchan
Rename HardwareBufferExternalTexture* to ImageExternalTexture* (#46786)
c25e1d8 
Image is the more accurate name and we will eventually have a
HardwareBufferExternalTexture in the future (see
https://developer.android.com/reference/android/graphics/HardwareBufferRenderer
available on Android >= 34).
@jason-simmons
Fix some image_external_texture entries in the license golden file (#…
92c7d4b 
…46790)
[web] Adds Noto Music fallback font (#46720)
97bcbd5 
Adds `Noto Music` font as a fallback font, and updates DEPS and font definitions after running the font roller script.

### Issues

Fixes: flutter/devtools#6149

----

![](https://media.giphy.com/media/3ohzAv6kdQ4tukSNK8/giphy-downsized.gif)

I used [the developer API](https://developers.google.com/fonts/docs/developer_api?apix_params=%7B%22family%22%3A%5B%22Noto%20Music%22%5D%7D) to make sure the api works with this font.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@gmackall
Revert "[Android] Add support for text processing actions (#44579)" (#…
8bf1460 
…46788)

This reverts commit d93fe23.

This change is causing integration tests to fail on attempts to roll the latest master version of flutter into the packages repo.

See a sample failure here: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8767521956894285553/+/u/Run_package_tests/native_integration_tests/stdout

The root cause seems to be that we are getting request codes in `onActivityResult` that we never added to the `requestsByCode` map, so the call to remove returns null (and we then call success getting a NPE).

More info: 
1. There is a [discussion in discord here](https://discord.com/channels/608014603317936148/1161718667566919761/1161721935927980052)
2. And the failure can be reproduced by running `dart run script/tool/bin/flutter_plugin_tools.dart native-test --android --packages file_selector` from the root of the packages repo (with a flutter checkout that contains these changes).

cc @bleroux 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@eyebrowsoffire
Switch to Chrome For Testing instead of Chromium (#46683)
5e788a8 
This switches over to using Chrome for Testing instead of Chromium. This requires some changes from the recipes repo (https://flutter-review.googlesource.com/c/recipes/+/51482) in order to coordinate the change in filestructure on the mac versions.
@dnfield
[Impeller] flutter_tester --enable-impeller (#46389)
791e90a 
This patch does the following:

- Updates `flutter_tester` to set up an Impeller rendering context and surface if `--enable-impeller` is set to true, using the Vulkan backend with Swiftshader.
- Updates `run_tests.py` to run all tests except the smoke test (that one really has no rendering impact whatsoever) with and without `--enable-impeller`.
- Updates a few tests to work that were trivial:
  - A couple tests needed updated goldens for very minor rendering differences. Filed flutter/flutter#135684 to track using Skia gold for this instead.
  - Disabled SKP screenshotting if Impeller is enabled, and updated the test checking that to verify an error is thrown if an SKP is requested.
  - The Dart GPU based test now asserts that the gpu context is available if Impeller is enabled, and does not deadlock if run in a single threaded mode.
  - We were missing some trace events around `Canvas::SaveLayer` for Impeller as compared to Skia.
  - A couple other tests had strict checks about exception messages that are slightly different between Skia and Impeller.
- I've filed bugs for other tests that may require a little more work, and skipped them for now. For FragmentProgram on Vulkan I reused an existing bug.

This is part of my attempt to address flutter/flutter#135693, although @chinmaygarde and I had slightly different ideas about how to do this.

The goals here are:

- Run the Dart unit tests we already have with Impeller enabled.
- Enable running more of the framework tests (including gold tests) with Impeller enabled.
- Run all of these tests via public `dart:ui` API rather than mucking around in C++ internals in the engine.
@jason-simmons
Run the binary size treemap script from the buildroot directory (#46740)
05e26c1 
This will produce a treemap where navigation starts from the buildroot
and the flutter and third_party source directories are shown as
siblings.
@skia-flutter-autoroll
Roll Skia from 2459d71707e0 to 924df8d87766 (7 revisions) (#46798)
9891e37 
https://skia.googlesource.com/skia.git/+log/2459d71707e0..924df8d87766

2023-10-11 [email protected] [graphite] Add PipelineDataGatherer to the precompilation path
2023-10-11 [email protected] Fix comment.
2023-10-11 [email protected] Minor fixes for buffet build
2023-10-11 [email protected] Reland "[bazel] Move test runners under //tools/testrunners.".
2023-10-11 [email protected] When waiting on client provided semaphores, only block fragment stage work.
2023-10-11 [email protected] Disallow layout(builtin=xxx) in non-module code.
2023-10-11 [email protected] Deploy CanvasKit 0.39.0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bdero
[Impeller] Bump impeller-cmake (#46764)
430abd5 
Bump with build fixes.
@bdero
[Impeller] Use triangle strips to dedupe rectangle vertices. (#46610)
356b197 
Remove a couple of duplicate verts in a bunch of situations.

Pedantic improvements: "Brandon, why are you like this" edition.
@skia-flutter-autoroll
Roll Dart SDK from 0732be6b823a to db2465f106ad (8 revisions) (#46797)
8055bc9 
https://dart.googlesource.com/sdk.git/+log/0732be6b823a..db2465f106ad

2023-10-11 [email protected] Version 3.3.0-14.0.dev
2023-10-11 [email protected] Version 3.3.0-13.0.dev
2023-10-11 [email protected] Version 3.3.0-12.0.dev
2023-10-11 [email protected] Version 3.3.0-11.0.dev
2023-10-11 [email protected] Version 3.3.0-10.0.dev
2023-10-11 [email protected] Version 3.3.0-9.0.dev
2023-10-10 [email protected] Version 3.3.0-8.0.dev
2023-10-10 [email protected] Version 3.3.0-7.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll
Roll Skia from 924df8d87766 to ff3c2e3d45bd (1 revision) (#46807)
d00fabf 
https://skia.googlesource.com/skia.git/+log/924df8d87766..ff3c2e3d45bd

2023-10-12 [email protected] [graphite] Track image size uniforms separately from proxies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@johnmccutchan
Cherrypick disable hardware buffer platform views for 3.16
e8b5cd0
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 16, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@johnmccutchan johnmccutchan mentioned this pull request Oct 16, 2023
Closed
@zanderso zanderso changed the base branch from main to flutter-3.16-candidate.0 October 16, 2023 20:27
@zanderso zanderso closed this Oct 16, 2023
@zanderso
Copy link
Member

zanderso commented Oct 16, 2023

@johnmccutchan The base commit and target branch for the cherry-pick PR should be the flutter-3.16-candidate.0 branch.

@johnmccutchan
Copy link
Contributor Author

johnmccutchan commented Oct 16, 2023

@zanderso #46968 should be better

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.